Address review: consolidate PROGRAMS_DIR constant; remove dead if-False branch

Agent-Logs-Url: https://github.com/githubnext/autoloop/sessions/c6a28e1a-8d38-4b61-8f7e-ea0c55200db1

Co-authored-by: mrjf <180956+mrjf@users.noreply.github.com>

Author: Copilot

.github/workflows/scripts/autoloop_scheduler.py

@@ -45,8 +45,7 @@
 from datetime import datetime, timedelta, timezone
 
 PROGRAMS_DIR = ".autoloop/programs"
-AUTOLOOP_DIR = ".autoloop/programs"
-TEMPLATE_FILE = os.path.join(AUTOLOOP_DIR, "example.md")
+TEMPLATE_FILE = os.path.join(PROGRAMS_DIR, "example.md")
 
 # Repo-memory files are cloned to /tmp/gh-aw/repo-memory/{id}/ where {id}
 # is derived from the branch-name configured in the tools section
@@ -216,9 +215,9 @@ def read_program_state(program_name, repo_memory_dir=REPO_MEMORY_DIR):
 
 def _bootstrap_template_if_missing():
     """Create ``.autoloop/programs/example.md`` if the directory is missing."""
-    if os.path.isdir(AUTOLOOP_DIR):
+    if os.path.isdir(PROGRAMS_DIR):
         return
-    os.makedirs(AUTOLOOP_DIR, exist_ok=True)
+    os.makedirs(PROGRAMS_DIR, exist_ok=True)
     bt = chr(96)  # backtick — keep gh-aw compiler happy if this ever gets inlined
     template = "\n".join([
         "<!-- AUTOLOOP:UNCONFIGURED -->",
@@ -279,8 +278,8 @@ def _scan_directory_programs():
 
 
 def _scan_bare_programs():
-    """Return paths of bare-markdown programs under ``AUTOLOOP_DIR``."""
-    return sorted(glob.glob(os.path.join(AUTOLOOP_DIR, "*.md")))
+    """Return paths of bare-markdown programs under ``PROGRAMS_DIR``."""
+    return sorted(glob.glob(os.path.join(PROGRAMS_DIR, "*.md")))
 
 
 def _fetch_issue_programs(repo, github_token):

tests/test_scheduler_e2e.py

@@ -99,9 +99,10 @@ def _run_scheduler(workdir, *, forced=None, repo="bogus.invalid/bogus"):
     os.makedirs(tmproot, exist_ok=True)
     env["TMPDIR"] = tmproot
 
-    # Wipe any stale output from a previous run within this workdir.
-    out_dir = os.path.join(tmproot, "gh-aw") if False else "/tmp/gh-aw"
-    out_path = os.path.join(out_dir, "autoloop.json")
+    # The scheduler always writes /tmp/gh-aw/autoloop.json. We can't redirect
+    # this via env vars without changing the script's contract, so tests share
+    # that path and clean up the previous run's output before invoking again.
+    out_path = "/tmp/gh-aw/autoloop.json"
     if os.path.exists(out_path):
         os.remove(out_path)
 

workflows/scripts/autoloop_scheduler.py

@@ -45,8 +45,7 @@
 from datetime import datetime, timedelta, timezone
 
 PROGRAMS_DIR = ".autoloop/programs"
-AUTOLOOP_DIR = ".autoloop/programs"
-TEMPLATE_FILE = os.path.join(AUTOLOOP_DIR, "example.md")
+TEMPLATE_FILE = os.path.join(PROGRAMS_DIR, "example.md")
 
 # Repo-memory files are cloned to /tmp/gh-aw/repo-memory/{id}/ where {id}
 # is derived from the branch-name configured in the tools section
@@ -216,9 +215,9 @@ def read_program_state(program_name, repo_memory_dir=REPO_MEMORY_DIR):
 
 def _bootstrap_template_if_missing():
     """Create ``.autoloop/programs/example.md`` if the directory is missing."""
-    if os.path.isdir(AUTOLOOP_DIR):
+    if os.path.isdir(PROGRAMS_DIR):
         return
-    os.makedirs(AUTOLOOP_DIR, exist_ok=True)
+    os.makedirs(PROGRAMS_DIR, exist_ok=True)
     bt = chr(96)  # backtick — keep gh-aw compiler happy if this ever gets inlined
     template = "\n".join([
         "<!-- AUTOLOOP:UNCONFIGURED -->",
@@ -279,8 +278,8 @@ def _scan_directory_programs():
 
 
 def _scan_bare_programs():
-    """Return paths of bare-markdown programs under ``AUTOLOOP_DIR``."""
-    return sorted(glob.glob(os.path.join(AUTOLOOP_DIR, "*.md")))
+    """Return paths of bare-markdown programs under ``PROGRAMS_DIR``."""
+    return sorted(glob.glob(os.path.join(PROGRAMS_DIR, "*.md")))
 
 
 def _fetch_issue_programs(repo, github_token):