Prevent duplicate workshop-page view transitions during hash navigation (#2386)

Author: Copilot

scripts/build-docs.test.js

@@ -191,12 +191,19 @@ test("workshop Markdown uses GitHub emoji shortcodes", () => {
   }
 });
 
-test("hash navigation opens details ancestors for targeted anchors", () => {
+test("hash navigation opens details ancestors after the destination page switches", () => {
   const { html } = buildDocs();
 
   assert.match(
     html,
     /function openDetailsAncestors\(target\) \{[\s\S]*detail\.open = true;[\s\S]*\}/
   );
-  assert.equal((html.match(/openDetailsAncestors\(target\);/g) ?? []).length, 2);
+  assert.match(
+    html,
+    /showWorkshopPage\(target, scrollPage && isPageTarget\);\s*if \(!isPageTarget\) \{\s*openDetailsAncestors\(target\);/
+  );
+  assert.match(
+    html,
+    /showWorkshopPage\(target, isPage\);\s*if \(!isPage\) \{\s*openDetailsAncestors\(target\);/
+  );
 });

scripts/lib/page-template.js

@@ -227,9 +227,11 @@ ${htmlContent}</main>
         return;
       }
 
-      openDetailsAncestors(target);
       const isPageTarget = target.matches('.markdown-body > details');
       showWorkshopPage(target, scrollPage && isPageTarget);
+      if (!isPageTarget) {
+        openDetailsAncestors(target);
+      }
       if (scrollPage && !isPageTarget) {
         target.scrollIntoView({ block: 'start' });
       }
@@ -274,9 +276,11 @@ ${htmlContent}</main>
         if (menuDialog.open) menuDialog.close();
         const isPage = target.matches('.markdown-body > details');
         history.pushState(null, '', link.getAttribute('href'));
-        openDetailsAncestors(target);
         showWorkshopPage(target, isPage);
-        if (!isPage) target.scrollIntoView({ block: 'start' });
+        if (!isPage) {
+          openDetailsAncestors(target);
+          target.scrollIntoView({ block: 'start' });
+        }
       }
     });