Skip to content

Commit 8a15d89

Browse files
Copilotpelikhan
andauthored
fix: update workshop-playwright-qa to use /tmp/gh-aw/agent/ as temp root (#1899)
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
1 parent 1d0a0d1 commit 8a15d89

2 files changed

Lines changed: 9 additions & 9 deletions

File tree

.github/workflows/workshop-playwright-qa.lock.yml

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/workshop-playwright-qa.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ steps:
4646
- name: Build workshop docs and start static server
4747
run: |
4848
set -euo pipefail
49-
mkdir -p /tmp/gh-aw/data /tmp/gh-aw/screenshots
49+
mkdir -p /tmp/gh-aw/agent/data /tmp/gh-aw/agent/screenshots
5050
5151
# Install dependencies (same set as deploy-pages.yml)
5252
npm install --no-save marked github-slugger marked-alert \
@@ -57,7 +57,7 @@ steps:
5757
5858
# Start a static HTTP server on port 4000
5959
npx --yes http-server dist -p 4000 --silent &
60-
echo $! > /tmp/gh-aw/data/server.pid
60+
echo $! > /tmp/gh-aw/agent/data/server.pid
6161
6262
# Wait until the server responds (up to 20 s)
6363
timeout 20 bash -c \
@@ -87,13 +87,13 @@ steps:
8787
{"name": "desktop", "width": 1280, "height": 800},
8888
],
8989
}
90-
pathlib.Path("/tmp/gh-aw/data/config.json").write_text(
90+
pathlib.Path("/tmp/gh-aw/agent/data/config.json").write_text(
9191
json.dumps(out, indent=2), encoding="utf-8"
9292
)
9393
print(f"Discovered {len(pages)} pages")
9494
PYEOF
9595
96-
echo "=== Config ===" && cat /tmp/gh-aw/data/config.json
96+
echo "=== Config ===" && cat /tmp/gh-aw/agent/data/config.json
9797
---
9898

9999
# Workshop Playwright QA
@@ -108,7 +108,7 @@ screenshots.
108108

109109
## Load Inputs
110110

111-
1. Read `/tmp/gh-aw/data/config.json`. It contains:
111+
1. Read `/tmp/gh-aw/agent/data/config.json`. It contains:
112112
- `base_url` — the local server URL (`http://127.0.0.1:4000/`)
113113
- `pages` — array of `{id, url}` objects, one per discovered workshop step
114114
plus a root entry
@@ -179,7 +179,7 @@ For every failed check, record a finding with:
179179
- `description` — a concise description of what failed and what was
180180
observed (include element selectors or text snippets where useful)
181181
- `screenshot_path` — path where a screenshot of the failure was saved
182-
(use `/tmp/gh-aw/screenshots/<page_id>-<viewport>-<short-slug>.png`)
182+
(use `/tmp/gh-aw/agent/screenshots/<page_id>-<viewport>-<short-slug>.png`)
183183
- `screenshot_asset_url` — GitHub asset URL returned by `upload_asset`
184184
after publishing the screenshot
185185

@@ -255,6 +255,6 @@ Group findings by `page_id`. For each page that has findings:
255255
- Screenshots must be taken before moving to the next finding so the
256256
browser state is captured at the moment of failure.
257257
- Every issue or comment with findings must embed the uploaded screenshot
258-
assets in Markdown, not local `/tmp/...` paths.
258+
assets in Markdown, not local file paths.
259259
- Never call write tools other than `create-issue`, `add-comment`,
260260
`upload_asset`, and `noop`.

0 commit comments

Comments
 (0)