Skip to content

Commit c60e0b6

Browse files
Copilotpelikhan
andauthored
Exempt learning:false dispatcher pages from checkpoint enforcement (#1846)
* Initial plan * fix: exempt learning false pages from checkpoints Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
1 parent 5beac21 commit c60e0b6

4 files changed

Lines changed: 8 additions & 6 deletions

File tree

.github/workflows/guidelines-enforcer.lock.yml

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/guidelines-enforcer.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ For each file in `target_files`:
177177
- **Schedule syntax** (agentic workflow `.md` files only): no raw cron syntax; use fuzzy expressions such as `schedule: daily`.
178178
- **UI-first design**: prefer GitHub UI paths; terminal commands are secondary unless required.
179179
- **Prerequisite discipline**: list only prerequisites needed for the current step; avoid future-looking requirements.
180-
- **Checkpoint presence** (workshop step files): every step file must end with a `## ✅ Checkpoint` section containing a markdown checklist.
180+
- **Checkpoint presence** (learning-step workshop files): every workshop step file must end with a `## ✅ Checkpoint` section containing a markdown checklist unless the file is marked `<!-- learning:false -->`; those dispatcher pages must omit the checkpoint section.
181181
- **Voice and tone**: second person, present tense, active voice; no dramatic or alarmist language.
182182
- **File split guideline**: a step file that diverges significantly in Terminal vs. UI paths should note whether the content should be split (do not auto-split, just flag it).
183183
3. For each violation found, record:

.github/workflows/workshop-author.lock.yml

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/workshop-author.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,9 @@ Create the file at `workshop/<filename>` using the `edit` tool. Follow **all** o
171171

172172
## Content Rules
173173

174-
### Structure (every file must follow this template)
174+
### Structure (every learning-step file must follow this template)
175+
176+
- Dispatcher pages marked `<!-- learning:false -->` are pure routing pages. They must omit the `## ✅ Checkpoint` section from this template.
175177

176178
```markdown
177179
# <Title>

0 commit comments

Comments
 (0)