improve(workshop): step 15 readability, callout density, and active-learning density#1785
Conversation
…s in step 15 - Reduce callout blocks from 4 to 3 (convert TIP to inline prose) - Rewrite short sentences into fuller technical prose (target FK 8-10) - Add hands-on Exercise: weekend skip condition with step-by-step instructions - Expand side-quest-15-01 with 'Combine multiple conditions' and 'Gather time-based context' sections covering && / || patterns and the date +%A shell technique — absorbing the 5 excess concepts from the main step - Update side-quest checkpoint with two new items Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
…section in step 15 Per code review: split exercise step 3 into three distinct action items (compile, trigger, inspect) and remove the now-redundant 'Test your condition' section — its skipped-step image is preserved inline. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
awmgmcpg
To allow these domains, add them to the
network.allowedlist in your workflow frontmatter:
network:
allowed:
- defaults
- "awmgmcpg"See Network Configuration for more information.
Generated by ✅ AW Accuracy PR Reviewer for #1785 · 68.6 AIC · ⌖ 4.81 AIC · ⊞ 4.3K
| ``` | ||
|
|
||
| This condition skips the compiler-generated agent job entirely when `commit_count` is `0`. | ||
| This condition is evaluated during [compilation](https://github.github.com/gh-aw/reference/compilation-process/) and embedded into the generated lock file, causing the agent job to be skipped entirely whenever `commit_count` evaluates to `'0'`. You can also reference the count inside your prompt text to give the model concrete context — for example: `"Summarise the last ${{ steps.recent.outputs.commit_count }} commits"` anchors the analysis to the actual number of changes rather than leaving the model to guess the scope. |
There was a problem hiding this comment.
Inaccuracy: if: is not evaluated during compilation.
The changed line states:
"This condition is evaluated during compilation and embedded into the generated lock file..."
Compilation only embeds the if: expression verbatim into the lock file — the expression is evaluated at runtime by GitHub Actions. This is necessarily true because steps.recent.outputs.commit_count is a step output that only exists when the workflow is running; it cannot be evaluated at compile time.
Suggested fix:
This condition is embedded into the generated lock file during [compilation](https://github.github.com/gh-aw/reference/compilation-process/); at runtime, GitHub Actions evaluates it and skips the agent job entirely whenever `commit_count` evaluates to `'0'`.
|
@Copiloy review comment at #1785 (comment) |
|
@copilot review comment at #1785 (comment) |
Compilation only embeds the expression verbatim into the lock file; GitHub Actions evaluates it at runtime when the step output exists. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Fixed in 8fb2c65. The sentence now reads: "This condition is embedded into the generated lock file during compilation; at runtime, GitHub Actions evaluates it and skips the agent job entirely whenever |
Step 15 scored below corpus mean: FK grade 6.2 (target 8–12), 4 callout blocks (limit 3), and activity density of 1.45 (target ≥ 3.0/100 words).
workshop/15-conditional-logic.md[!TIP]about${{ steps.recent.outputs.commit_count }}into inline prose in the frontmatter sectiongit log→wc -l→tr -d ' '→$GITHUB_OUTPUT) in a single cohesive sentence&&conditions, compile, trigger, and verify the skipped-state icon in the Actions log$GITHUB_OUTPUT/ expression minutiae from the NOTE callout; replaced with a richer pointer to the side questworkshop/side-quest-15-01-expressions-and-contexts.mdAbsorbs the 5 excess concepts removed from the main step:
&&/||operators with three practical YAML patternsdate +%Apattern for conditions not available in any GitHub Actions context object, tied directly to the weekend-skip exercise