Fix CI: resolve typecheck errors, lint errors, and formatting issues

Typecheck fixes:
- to_from_dict.ts: fix overload signature compatibility and undefined index type
- string_ops.ts: widen StrInput type to accept readonly Scalar[]
- string_ops_extended.ts: fix overload compatibility via StrInput widening
- where_mask.ts: use Index.contains() instead of non-existent indexOf()
- notna_isna.test.ts: add dfFromMap helper for proper 2-arg DataFrame constructor
- string_ops.test.ts: use spread to copy readonly array before sort
- window_extended.test.ts: use .values instead of .toArray() on SeriesLike

Lint fixes:
- biome.json: add overrides for benchmarks (noConsole) and tests (useLiteralKeys)
- api_types.ts: use typed casts instead of Record index access
- string_ops.ts: replace forEach with for-of, refactor assign-in-expression
- string_ops_extended.ts: refactor assign-in-expression in extractGroupNames
- numeric_extended.ts: remove useless else after return
- window_extended.ts: remove useless switch case before default
- numeric_extended.test.ts: replace non-null assertions with nullish coalescing
- rolling_apply.test.ts: replace non-null assertions with nullish coalescing
- format_ops.test.ts: use Number.POSITIVE_INFINITY, fix approximate constants

Formatting:
- Apply biome format --write across all affected files

Agent-Logs-Url: https://github.com/githubnext/tsessebe/sessions/4d41059e-6981-42f5-b701-befb01f01bb8

Co-authored-by: mrjf <180956+mrjf@users.noreply.github.com>

Author: Copilot

benchmarks/tsb/bench_dataframe_dropna.ts

@@ -7,7 +7,9 @@ const ROWS = 100_000;
 const WARMUP = 5;
 const ITERATIONS = 20;
 
-const a: (number | null)[] = Array.from({ length: ROWS }, (_, i) => (i % 10 === 0 ? null : i * 1.1));
+const a: (number | null)[] = Array.from({ length: ROWS }, (_, i) =>
+  i % 10 === 0 ? null : i * 1.1,
+);
 const b: (number | null)[] = Array.from({ length: ROWS }, (_, i) => (i % 7 === 0 ? null : i * 2.2));
 const df = DataFrame.fromColumns({ a, b });
 

benchmarks/tsb/bench_series_fillna.ts

@@ -8,7 +8,9 @@ const WARMUP = 5;
 const ITERATIONS = 20;
 
 // Create series with every 5th value as null
-const data: (number | null)[] = Array.from({ length: ROWS }, (_, i) => (i % 5 === 0 ? null : i * 1.1));
+const data: (number | null)[] = Array.from({ length: ROWS }, (_, i) =>
+  i % 5 === 0 ? null : i * 1.1,
+);
 const s = new Series({ data });
 
 for (let i = 0; i < WARMUP; i++) {

benchmarks/tsb/bench_series_shift.ts

@@ -19,7 +19,9 @@ function shiftSeries(series: Series<number>): Series<number | null> {
   const shifted: (number | null)[] = [null];
   for (let i = 0; i < vals.length - 1; i++) {
     const v = vals[i];
-    if (v !== undefined) shifted.push(v);
+    if (v !== undefined) {
+      shifted.push(v);
+    }
   }
   return new Series({ data: shifted });
 }

biome.json

@@ -69,6 +69,20 @@
         "rules": {
           "nursery": {
             "noSecrets": "off"
+          },
+          "complexity": {
+            "useLiteralKeys": "off"
+          }
+        }
+      }
+    },
+    {
+      "include": ["benchmarks/**"],
+      "linter": {
+        "rules": {
+          "suspicious": {
+            "noConsole": "off",
+            "noConsoleLog": "off"
           }
         }
       }

src/core/api_types.ts

@@ -23,8 +23,8 @@
  * @module
  */
 
-import { Dtype } from "./dtype.ts";
 import type { DtypeName } from "../types.ts";
+import { Dtype } from "./dtype.ts";
 
 // ─── internal helper ──────────────────────────────────────────────────────────
 
@@ -95,14 +95,19 @@ export function isListLike(val: unknown): boolean {
     return false;
   }
   // Has Symbol.iterator and is not a plain number/boolean/bigint/symbol
-  if (typeof val === "number" || typeof val === "boolean" || typeof val === "bigint" || typeof val === "symbol") {
+  if (
+    typeof val === "number" ||
+    typeof val === "boolean" ||
+    typeof val === "bigint" ||
+    typeof val === "symbol"
+  ) {
     return false;
   }
   if (typeof val === "object" || typeof val === "function") {
     if (Symbol.iterator in (val as object)) {
       return true;
     }
-    const len = (val as Record<string, unknown>)["length"];
+    const len = (val as { length?: unknown }).length;
     if (typeof len === "number" && len >= 0 && Number.isInteger(len)) {
       return true;
     }
@@ -134,7 +139,7 @@ export function isArrayLike(val: unknown): boolean {
   if (typeof val !== "object" && typeof val !== "function") {
     return false;
   }
-  const len = (val as Record<string, unknown>)["length"];
+  const len = (val as { length?: unknown }).length;
   return typeof len === "number" && len >= 0 && Number.isInteger(len);
 }
 
@@ -192,7 +197,7 @@ export function isIterator(val: unknown): boolean {
   if (typeof val !== "object" && typeof val !== "function") {
     return false;
   }
-  return typeof (val as Record<string, unknown>)["next"] === "function";
+  return typeof (val as { next?: unknown }).next === "function";
 }
 
 /**

src/core/index.ts

@@ -15,7 +15,13 @@ export { CategoricalAccessor } from "./cat_accessor.ts";
 export type { CatSeriesLike } from "./cat_accessor.ts";
 export { MultiIndex } from "./multi_index.ts";
 export type { MultiIndexOptions } from "./multi_index.ts";
-export { insertColumn, popColumn, reorderColumns, moveColumn, dataFrameFromPairs } from "./insert_pop.ts";
+export {
+  insertColumn,
+  popColumn,
+  reorderColumns,
+  moveColumn,
+  dataFrameFromPairs,
+} from "./insert_pop.ts";
 export type { PopResult } from "./insert_pop.ts";
 export { toDictOriented, fromDictOriented } from "./to_from_dict.ts";
 export type {

src/core/insert_pop.ts

@@ -27,7 +27,7 @@
  */
 
 import type { Label, Scalar } from "../types.ts";
-import { Index } from "./base-index.ts";
+import type { Index } from "./base-index.ts";
 import { DataFrame } from "./frame.ts";
 import { Series } from "./series.ts";
 

src/core/pipe_apply.ts

@@ -45,12 +45,7 @@ import type { Label, Scalar } from "../types.ts";
 export function pipe<A>(value: A): A;
 export function pipe<A, B>(value: A, fn1: (a: A) => B): B;
 export function pipe<A, B, C>(value: A, fn1: (a: A) => B, fn2: (b: B) => C): C;
-export function pipe<A, B, C, D>(
-  value: A,
-  fn1: (a: A) => B,
-  fn2: (b: B) => C,
-  fn3: (c: C) => D,
-): D;
+export function pipe<A, B, C, D>(value: A, fn1: (a: A) => B, fn2: (b: B) => C, fn3: (c: C) => D): D;
 export function pipe<A, B, C, D, E>(
   value: A,
   fn1: (a: A) => B,
@@ -119,7 +114,11 @@ export function seriesApply(
   for (let i = 0; i < n; i++) {
     out[i] = fn(series.iat(i), series.index.at(i), i);
   }
-  return new Series({ data: out, index: series.index, ...(series.name !== null ? { name: series.name } : {}) });
+  return new Series({
+    data: out,
+    index: series.index,
+    ...(series.name !== null ? { name: series.name } : {}),
+  });
 }
 
 /**
@@ -141,7 +140,11 @@ export function seriesTransform(
   for (let i = 0; i < n; i++) {
     out[i] = fn(series.iat(i));
   }
-  return new Series({ data: out, index: series.index, ...(series.name !== null ? { name: series.name } : {}) });
+  return new Series({
+    data: out,
+    index: series.index,
+    ...(series.name !== null ? { name: series.name } : {}),
+  });
 }
 
 // ─── DataFrame apply ──────────────────────────────────────────────────────────
@@ -272,7 +275,11 @@ export function dataFrameTransform(
  */
 export function dataFrameTransformRows(
   df: DataFrame,
-  fn: (row: Readonly<Record<string, Scalar>>, rowLabel: Label, position: number) => Readonly<Record<string, Scalar>>,
+  fn: (
+    row: Readonly<Record<string, Scalar>>,
+    rowLabel: Label,
+    position: number,
+  ) => Readonly<Record<string, Scalar>>,
 ): DataFrame {
   const colNames = df.columns.values as readonly string[];
   const rowLabels = df.index.values as readonly Label[];
@@ -290,7 +297,9 @@ export function dataFrameTransformRows(
     const rowOut = fn(rowIn, rowLabels[i] as Label, i);
     for (const c of colNames) {
       const colArr = colArrays.get(c);
-      if (colArr === undefined) continue;
+      if (colArr === undefined) {
+        continue;
+      }
       // use the transformed value if present, else keep original
       colArr[i] = c in rowOut ? (rowOut[c] as Scalar) : rowIn[c];
     }

src/core/to_from_dict.ts

@@ -25,12 +25,20 @@
 import type { Label, Scalar } from "../types.ts";
 import { Index } from "./base-index.ts";
 import { DataFrame } from "./frame.ts";
-import { Series } from "./series.ts";
+import type { Series } from "./series.ts";
 
 // ─── public types ──────────────────────────────────────────────────────────────
 
 /** Orient values supported by {@link toDictOriented}. */
-export type ToDictOrient = "dict" | "columns" | "list" | "series" | "split" | "tight" | "records" | "index";
+export type ToDictOrient =
+  | "dict"
+  | "columns"
+  | "list"
+  | "series"
+  | "split"
+  | "tight"
+  | "records"
+  | "index";
 
 /** Orient values supported by {@link fromDictOriented}. */
 export type FromDictOrient = "columns" | "index" | "split" | "tight";
@@ -78,17 +86,23 @@ function isDefaultRange(labels: readonly Label[]): boolean {
  * @param df     Source DataFrame.
  * @param orient Output structure. Defaults to `"dict"`.
  */
-export function toDictOriented(df: DataFrame, orient: "dict" | "columns"): Record<string, Record<string, Scalar>>;
+export function toDictOriented(
+  df: DataFrame,
+  orient: "dict" | "columns",
+): Record<string, Record<string, Scalar>>;
 export function toDictOriented(df: DataFrame, orient: "list"): Record<string, Scalar[]>;
 export function toDictOriented(df: DataFrame, orient: "series"): Record<string, Series<Scalar>>;
 export function toDictOriented(df: DataFrame, orient: "split"): DictSplit;
 export function toDictOriented(df: DataFrame, orient: "tight"): DictTight;
 export function toDictOriented(df: DataFrame, orient: "records"): Record<string, Scalar>[];
-export function toDictOriented(df: DataFrame, orient: "index"): Record<string, Record<string, Scalar>>;
+export function toDictOriented(
+  df: DataFrame,
+  orient: "index",
+): Record<string, Record<string, Scalar>>;
 export function toDictOriented(
   df: DataFrame,
   orient: ToDictOrient = "dict",
-): Record<string, unknown> | unknown[] {
+): Record<string, unknown> | unknown[] | DictSplit | DictTight {
   const colNames = [...df.columns.values];
   const rowLabels = [...(df.index.values as Label[])];
   const nRows = df.index.size;
@@ -201,10 +215,7 @@ export function fromDictOriented(
   orient: "index",
 ): DataFrame;
 export function fromDictOriented(data: SplitInput, orient: "split" | "tight"): DataFrame;
-export function fromDictOriented(
-  data: unknown,
-  orient: FromDictOrient = "columns",
-): DataFrame {
+export function fromDictOriented(data: unknown, orient: FromDictOrient = "columns"): DataFrame {
   switch (orient) {
     case "columns": {
       const colsData = data as Record<string, readonly Scalar[]>;
@@ -266,8 +277,11 @@ function buildFromSplit(input: SplitInput): DataFrame {
   for (const row of data) {
     for (let j = 0; j < columns.length; j++) {
       const col = columns[j];
+      if (col === undefined) {
+        continue;
+      }
       const arr = colArrays[col];
-      if (col !== undefined && arr !== undefined) {
+      if (arr !== undefined) {
         arr.push(row[j] ?? null);
       }
     }

src/index.ts

@@ -115,10 +115,22 @@ export type { ClipOptions, RoundOptions, DataFrameElemOptions } from "./stats/in
 export { valueCounts, dataFrameValueCounts } from "./stats/index.ts";
 export type { ValueCountsOptions, DataFrameValueCountsOptions } from "./stats/index.ts";
 
-export { insertColumn, popColumn, reorderColumns, moveColumn, dataFrameFromPairs } from "./core/index.ts";
+export {
+  insertColumn,
+  popColumn,
+  reorderColumns,
+  moveColumn,
+  dataFrameFromPairs,
+} from "./core/index.ts";
 export type { PopResult } from "./core/index.ts";
 export { toDictOriented, fromDictOriented } from "./core/index.ts";
-export type { ToDictOrient, FromDictOrient, DictSplit, DictTight, SplitInput } from "./core/index.ts";
+export type {
+  ToDictOrient,
+  FromDictOrient,
+  DictSplit,
+  DictTight,
+  SplitInput,
+} from "./core/index.ts";
 export { wideToLong } from "./reshape/index.ts";
 export type { WideToLongOptions } from "./reshape/index.ts";
 export { cut, qcut } from "./stats/index.ts";
@@ -132,7 +144,16 @@ export type {
   SeriesWhereOptions,
   DataFrameWhereOptions,
 } from "./stats/index.ts";
-export { isna, notna, isnull, notnull, fillna, dropna, countna, countValid } from "./stats/index.ts";
+export {
+  isna,
+  notna,
+  isnull,
+  notnull,
+  fillna,
+  dropna,
+  countna,
+  countValid,
+} from "./stats/index.ts";
 export type { IsnaInput, FillnaOptions, DropnaOptions } from "./stats/index.ts";
 export {
   getAttrs,