Fix all CI lint errors: add benchmarks/ to biome ignore, fix formatting, TS4111 conflicts, noAssignInExpressions, noForEach, noNonNullAssertion

- Add benchmarks/** to biome.json ignore (benchmarks need console.log)
- Auto-format all source files with biome format --write
- Apply safe biome lint fixes (import sorting, useImportType, noUselessElse, etc.)
- Fix noAssignInExpressions in string_ops.ts and string_ops_extended.ts
  (restructure while loops to avoid assignment in condition)
- Fix noForEach in string_ops.ts (use for...of instead)
- Fix noNonNullAssertion in test files (use ?? 0 instead of !)
- Add biome-ignore comments for useLiteralKeys where bracket access is
  required by TypeScript's noPropertyAccessFromIndexSignature (TS4111)

Agent-Logs-Url: https://github.com/githubnext/tsessebe/sessions/1df0cfcf-bce4-4db6-ad4b-cc73af955b11

Co-authored-by: mrjf <180956+mrjf@users.noreply.github.com>

Author: Copilot

biome.json

@@ -7,7 +7,14 @@
   },
   "files": {
     "ignoreUnknown": false,
-    "ignore": ["dist/**", "node_modules/**", "*.d.ts", "playground/**/*.js", "playground/serve.ts"]
+    "ignore": [
+      "dist/**",
+      "node_modules/**",
+      "*.d.ts",
+      "playground/**/*.js",
+      "playground/serve.ts",
+      "benchmarks/**"
+    ]
   },
   "formatter": {
     "enabled": true,

src/core/api_types.ts

@@ -23,8 +23,8 @@
  * @module
  */
 
-import { Dtype } from "./dtype.ts";
 import type { DtypeName } from "../types.ts";
+import { Dtype } from "./dtype.ts";
 
 // ─── internal helper ──────────────────────────────────────────────────────────
 
@@ -95,13 +95,19 @@ export function isListLike(val: unknown): boolean {
     return false;
   }
   // Has Symbol.iterator and is not a plain number/boolean/bigint/symbol
-  if (typeof val === "number" || typeof val === "boolean" || typeof val === "bigint" || typeof val === "symbol") {
+  if (
+    typeof val === "number" ||
+    typeof val === "boolean" ||
+    typeof val === "bigint" ||
+    typeof val === "symbol"
+  ) {
     return false;
   }
   if (typeof val === "object" || typeof val === "function") {
     if (Symbol.iterator in (val as object)) {
       return true;
     }
+    // biome-ignore lint/complexity/useLiteralKeys: TS4111 index signature requires bracket access
     const len = (val as Record<string, unknown>)["length"];
     if (typeof len === "number" && len >= 0 && Number.isInteger(len)) {
       return true;
@@ -134,6 +140,7 @@ export function isArrayLike(val: unknown): boolean {
   if (typeof val !== "object" && typeof val !== "function") {
     return false;
   }
+  // biome-ignore lint/complexity/useLiteralKeys: TS4111 index signature requires bracket access
   const len = (val as Record<string, unknown>)["length"];
   return typeof len === "number" && len >= 0 && Number.isInteger(len);
 }
@@ -192,6 +199,7 @@ export function isIterator(val: unknown): boolean {
   if (typeof val !== "object" && typeof val !== "function") {
     return false;
   }
+  // biome-ignore lint/complexity/useLiteralKeys: TS4111 index signature requires bracket access
   return typeof (val as Record<string, unknown>)["next"] === "function";
 }
 

src/core/attrs.ts

@@ -227,7 +227,9 @@ export function setAttr(obj: object, key: string, value: unknown): void {
  */
 export function deleteAttr(obj: object, key: string): void {
   const existing = registry.get(obj);
-  if (existing === undefined) return;
+  if (existing === undefined) {
+    return;
+  }
   const { [key]: _removed, ...rest } = existing;
   if (Object.keys(rest).length === 0) {
     registry.delete(obj);

src/core/index.ts

@@ -15,7 +15,13 @@ export { CategoricalAccessor } from "./cat_accessor.ts";
 export type { CatSeriesLike } from "./cat_accessor.ts";
 export { MultiIndex } from "./multi_index.ts";
 export type { MultiIndexOptions } from "./multi_index.ts";
-export { insertColumn, popColumn, reorderColumns, moveColumn, dataFrameFromPairs } from "./insert_pop.ts";
+export {
+  insertColumn,
+  popColumn,
+  reorderColumns,
+  moveColumn,
+  dataFrameFromPairs,
+} from "./insert_pop.ts";
 export type { PopResult } from "./insert_pop.ts";
 export { toDictOriented, fromDictOriented } from "./to_from_dict.ts";
 export type {

src/core/insert_pop.ts

@@ -27,7 +27,7 @@
  */
 
 import type { Label, Scalar } from "../types.ts";
-import { Index } from "./base-index.ts";
+import type { Index } from "./base-index.ts";
 import { DataFrame } from "./frame.ts";
 import { Series } from "./series.ts";
 

src/core/pipe_apply.ts

@@ -45,12 +45,7 @@ import type { Label, Scalar } from "../types.ts";
 export function pipe<A>(value: A): A;
 export function pipe<A, B>(value: A, fn1: (a: A) => B): B;
 export function pipe<A, B, C>(value: A, fn1: (a: A) => B, fn2: (b: B) => C): C;
-export function pipe<A, B, C, D>(
-  value: A,
-  fn1: (a: A) => B,
-  fn2: (b: B) => C,
-  fn3: (c: C) => D,
-): D;
+export function pipe<A, B, C, D>(value: A, fn1: (a: A) => B, fn2: (b: B) => C, fn3: (c: C) => D): D;
 export function pipe<A, B, C, D, E>(
   value: A,
   fn1: (a: A) => B,
@@ -119,7 +114,11 @@ export function seriesApply(
   for (let i = 0; i < n; i++) {
     out[i] = fn(series.iat(i), series.index.at(i), i);
   }
-  return new Series({ data: out, index: series.index, ...(series.name !== null ? { name: series.name } : {}) });
+  return new Series({
+    data: out,
+    index: series.index,
+    ...(series.name !== null ? { name: series.name } : {}),
+  });
 }
 
 /**
@@ -141,7 +140,11 @@ export function seriesTransform(
   for (let i = 0; i < n; i++) {
     out[i] = fn(series.iat(i));
   }
-  return new Series({ data: out, index: series.index, ...(series.name !== null ? { name: series.name } : {}) });
+  return new Series({
+    data: out,
+    index: series.index,
+    ...(series.name !== null ? { name: series.name } : {}),
+  });
 }
 
 // ─── DataFrame apply ──────────────────────────────────────────────────────────
@@ -272,7 +275,11 @@ export function dataFrameTransform(
  */
 export function dataFrameTransformRows(
   df: DataFrame,
-  fn: (row: Readonly<Record<string, Scalar>>, rowLabel: Label, position: number) => Readonly<Record<string, Scalar>>,
+  fn: (
+    row: Readonly<Record<string, Scalar>>,
+    rowLabel: Label,
+    position: number,
+  ) => Readonly<Record<string, Scalar>>,
 ): DataFrame {
   const colNames = df.columns.values as readonly string[];
   const rowLabels = df.index.values as readonly Label[];
@@ -290,7 +297,9 @@ export function dataFrameTransformRows(
     const rowOut = fn(rowIn, rowLabels[i] as Label, i);
     for (const c of colNames) {
       const colArr = colArrays.get(c);
-      if (colArr === undefined) continue;
+      if (colArr === undefined) {
+        continue;
+      }
       // use the transformed value if present, else keep original
       colArr[i] = c in rowOut ? (rowOut[c] as Scalar) : rowIn[c];
     }

src/core/to_from_dict.ts

@@ -25,12 +25,20 @@
 import type { Label, Scalar } from "../types.ts";
 import { Index } from "./base-index.ts";
 import { DataFrame } from "./frame.ts";
-import { Series } from "./series.ts";
+import type { Series } from "./series.ts";
 
 // ─── public types ──────────────────────────────────────────────────────────────
 
 /** Orient values supported by {@link toDictOriented}. */
-export type ToDictOrient = "dict" | "columns" | "list" | "series" | "split" | "tight" | "records" | "index";
+export type ToDictOrient =
+  | "dict"
+  | "columns"
+  | "list"
+  | "series"
+  | "split"
+  | "tight"
+  | "records"
+  | "index";
 
 /** Orient values supported by {@link fromDictOriented}. */
 export type FromDictOrient = "columns" | "index" | "split" | "tight";
@@ -78,13 +86,19 @@ function isDefaultRange(labels: readonly Label[]): boolean {
  * @param df     Source DataFrame.
  * @param orient Output structure. Defaults to `"dict"`.
  */
-export function toDictOriented(df: DataFrame, orient: "dict" | "columns"): Record<string, Record<string, Scalar>>;
+export function toDictOriented(
+  df: DataFrame,
+  orient: "dict" | "columns",
+): Record<string, Record<string, Scalar>>;
 export function toDictOriented(df: DataFrame, orient: "list"): Record<string, Scalar[]>;
 export function toDictOriented(df: DataFrame, orient: "series"): Record<string, Series<Scalar>>;
 export function toDictOriented(df: DataFrame, orient: "split"): DictSplit;
 export function toDictOriented(df: DataFrame, orient: "tight"): DictTight;
 export function toDictOriented(df: DataFrame, orient: "records"): Record<string, Scalar>[];
-export function toDictOriented(df: DataFrame, orient: "index"): Record<string, Record<string, Scalar>>;
+export function toDictOriented(
+  df: DataFrame,
+  orient: "index",
+): Record<string, Record<string, Scalar>>;
 export function toDictOriented(
   df: DataFrame,
   orient: ToDictOrient = "dict",
@@ -201,10 +215,7 @@ export function fromDictOriented(
   orient: "index",
 ): DataFrame;
 export function fromDictOriented(data: SplitInput, orient: "split" | "tight"): DataFrame;
-export function fromDictOriented(
-  data: unknown,
-  orient: FromDictOrient = "columns",
-): DataFrame {
+export function fromDictOriented(data: unknown, orient: FromDictOrient = "columns"): DataFrame {
   switch (orient) {
     case "columns": {
       const colsData = data as Record<string, readonly Scalar[]>;

src/index.ts

@@ -115,10 +115,22 @@ export type { ClipOptions, RoundOptions, DataFrameElemOptions } from "./stats/in
 export { valueCounts, dataFrameValueCounts } from "./stats/index.ts";
 export type { ValueCountsOptions, DataFrameValueCountsOptions } from "./stats/index.ts";
 
-export { insertColumn, popColumn, reorderColumns, moveColumn, dataFrameFromPairs } from "./core/index.ts";
+export {
+  insertColumn,
+  popColumn,
+  reorderColumns,
+  moveColumn,
+  dataFrameFromPairs,
+} from "./core/index.ts";
 export type { PopResult } from "./core/index.ts";
 export { toDictOriented, fromDictOriented } from "./core/index.ts";
-export type { ToDictOrient, FromDictOrient, DictSplit, DictTight, SplitInput } from "./core/index.ts";
+export type {
+  ToDictOrient,
+  FromDictOrient,
+  DictSplit,
+  DictTight,
+  SplitInput,
+} from "./core/index.ts";
 export { wideToLong } from "./reshape/index.ts";
 export type { WideToLongOptions } from "./reshape/index.ts";
 export { cut, qcut } from "./stats/index.ts";
@@ -132,7 +144,16 @@ export type {
   SeriesWhereOptions,
   DataFrameWhereOptions,
 } from "./stats/index.ts";
-export { isna, notna, isnull, notnull, fillna, dropna, countna, countValid } from "./stats/index.ts";
+export {
+  isna,
+  notna,
+  isnull,
+  notnull,
+  fillna,
+  dropna,
+  countna,
+  countValid,
+} from "./stats/index.ts";
 export type { IsnaInput, FillnaOptions, DropnaOptions } from "./stats/index.ts";
 export {
   getAttrs,

src/reshape/wide_to_long.ts

@@ -38,10 +38,10 @@
  * @module
  */
 
-import type { Label, Scalar } from "../types.ts";
-import { Index } from "../core/base-index.ts";
+import type { Index } from "../core/base-index.ts";
 import { DataFrame } from "../core/frame.ts";
 import { RangeIndex } from "../core/range-index.ts";
+import type { Label, Scalar } from "../types.ts";
 
 // ─── public types ──────────────────────────────────────────────────────────────
 
@@ -100,7 +100,7 @@ function collectSuffixes(
     // Sort numerically when both look like integers, otherwise lexicographically.
     const na = Number(a);
     const nb = Number(b);
-    if (!Number.isNaN(na) && !Number.isNaN(nb)) {
+    if (!(Number.isNaN(na) || Number.isNaN(nb))) {
       return na - nb;
     }
     return a < b ? -1 : a > b ? 1 : 0;
@@ -193,7 +193,8 @@ export function wideToLong(
         const arr = stubArrays[stub];
         if (arr !== undefined) {
           const wideCol = df.get(wideColName);
-          const val: Scalar = wideCol !== undefined ? ((wideCol.values[row] ?? null) as Scalar) : null;
+          const val: Scalar =
+            wideCol !== undefined ? ((wideCol.values[row] ?? null) as Scalar) : null;
           arr.push(val);
         }
       }