Commit 3df01bf
committed
fix(query): use
To ensure that the user retains a cleaner history of browsing
through Flat Viewer, set query parameters with `replaceIn` when:
repo-detail:
- File/commit metadata is loaded
json-detail-container:
- A file is loaded and a tab chosen
- `onGridChange()` is invoked
The latter bears noting, as this means we will no longer retain
a user's history of manipulating the grid. Given that `onGridChange()`
is invoked when data is loaded into the grid, we think that ensuring
a cleaner overall history is more important to the user than retaining
the specific click history for grid manipuation, which the user may
find difficult to follow anyway.replaceIn to avoid mangling browser history1 parent 5d6171d commit 3df01bf
2 files changed
Lines changed: 12 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
45 | | - | |
| 45 | + | |
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
| |||
89 | 89 | | |
90 | 90 | | |
91 | 91 | | |
92 | | - | |
93 | | - | |
94 | | - | |
95 | | - | |
96 | | - | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
97 | 100 | | |
98 | 101 | | |
99 | 102 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
52 | | - | |
| 52 | + | |
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
| |||
73 | 73 | | |
74 | 74 | | |
75 | 75 | | |
76 | | - | |
| 76 | + | |
77 | 77 | | |
78 | 78 | | |
79 | | - | |
| 79 | + | |
80 | 80 | | |
81 | 81 | | |
82 | 82 | | |
| |||
0 commit comments