fix: correct repository url to electron-menubar for npm provenance#93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
Publish to npmjob for the 10.1.0 release failed with a provenance validation error:The repo was renamed from
gitify-app/menubartogitify-app/electron-menubar, butpackage.jsonstill pointed at the old name. npm provenance requiresrepository.urlto exactly match the GitHub repository the build ran in, so publishing was rejected (10.1.0 was never published to npm;latestis still 10.0.2).Changes
homepage,bugs.url, andrepository.urlatgitify-app/electron-menubargit+https://form forrepository.urlto clear thenpm pkg fixwarningFollow-up
After merge, re-run the Publish workflow (
workflow_dispatchonpublish.yml, or via the next release) to publish 10.1.0 with the corrected provenance.