refactor types

Signed-off-by: Adam Setch <adam.setch@outlook.com>

Author: setchy

src/renderer/utils/api/client.ts

@@ -15,6 +15,7 @@ import type {
   GetCommitCommentResponse,
   GetCommitResponse,
   GetReleaseResponse,
+  HeadNotificationsResponse,
   IgnoreNotificationThreadSubscriptionResponse,
   ListNotificationsForAuthenticatedUserResponse,
   MarkNotificationThreadAsDoneResponse,
@@ -56,7 +57,7 @@ import {
 export function headNotifications(
   hostname: Hostname,
   token: Token,
-): AxiosPromise<void> {
+): AxiosPromise<HeadNotificationsResponse> {
   const url = getGitHubAPIBaseUrl(hostname);
   url.pathname += 'notifications';
 

src/renderer/utils/api/graphql/generated/graphql.ts

@@ -21652,6 +21652,7 @@ export type PullRequestSuggestedReviewerActorsArgs = {
   before?: InputMaybe<Scalars['String']['input']>;
   first?: InputMaybe<Scalars['Int']['input']>;
   last?: InputMaybe<Scalars['Int']['input']>;
+  query?: InputMaybe<Scalars['String']['input']>;
 };
 
 

src/renderer/utils/api/types.ts

@@ -1,3 +1,4 @@
+import type { components } from '@octokit/openapi-types';
 import type { Endpoints } from '@octokit/types';
 
 import type { Link } from '../../types';
@@ -10,12 +11,6 @@ export interface GitHubRESTError {
 export type ListNotificationsForAuthenticatedUserResponse =
   Endpoints['GET /notifications']['response']['data'];
 
-export type MarkNotificationThreadAsReadResponse =
-  Endpoints['PATCH /notifications/threads/{thread_id}']['response']['data'];
-
-export type MarkNotificationThreadAsDoneResponse =
-  Endpoints['DELETE /notifications/threads/{thread_id}']['response']['data'];
-
 export type IgnoreNotificationThreadSubscriptionResponse =
   Endpoints['PUT /notifications/threads/{thread_id}/subscription']['response']['data'];
 
@@ -31,5 +26,18 @@ export type GetReleaseResponse =
 export type RawGitHubNotification =
   Endpoints['GET /notifications']['response']['data'][number];
 
-// FIXME - replace this if possible
-export type RawUser = Endpoints['GET /users/{username}']['response']['data'];
+export type RawUser = components['schemas']['simple-user'];
+
+/**
+ * These API endpoints don't return a response body
+ */
+// HEAD request - no response body
+export type HeadNotificationsResponse = NoResponseBody;
+
+// Endpoints['PATCH /notifications/threads/{thread_id}']['response']['data'];
+export type MarkNotificationThreadAsReadResponse = NoResponseBody;
+
+// Endpoints['DELETE /notifications/threads/{thread_id}']['response']['data']
+export type MarkNotificationThreadAsDoneResponse = NoResponseBody;
+
+type NoResponseBody = void;