Merge pull request #38 from ekonstantinidis/cc-issues

Fix code climate issues

Author: ekonstantinidis

main.js

@@ -12,7 +12,7 @@ var iconIdle = path.join(__dirname, 'images', 'tray-idleTemplate.png');
 var iconActive = path.join(__dirname, 'images', 'tray-active.png');
 
 app.on('ready', function(){
-  appIcon = new Tray(iconIdle);
+  var appIcon = new Tray(iconIdle);
   initWindow();
 
   appIcon.on('clicked', function clicked (e, bounds) {
@@ -68,29 +68,28 @@ app.on('ready', function(){
       ]
     }];
 
-    menu = Menu.buildFromTemplate(template);
+    var menu = Menu.buildFromTemplate(template);
     Menu.setApplicationMenu(menu);
   }
 
   function hideWindow () {
-    if (!appIcon.window) return;
+    if (!appIcon.window) { return; }
     appIcon.window.hide();
   }
 
-  ipc.on('reopen-window', function(event) {
+  ipc.on('reopen-window', function() {
     appIcon.window.show();
   });
 
   ipc.on('update-icon', function(event, arg) {
-    var icon;
-    if (arg == "TrayActive") {
+    if (arg === "TrayActive") {
       appIcon.setImage(iconActive);
     } else {
       appIcon.setImage(iconIdle);
     }
   });
 
-  ipc.on('app-quit', function(event) {
+  ipc.on('app-quit', function() {
     app.quit();
   });
 

src/js/__tests__/__mocks__/superagent.js

@@ -47,7 +47,7 @@ superagent.mockError = null;
 superagent.mockDelay = false;
 
 function __setResponse (status, ok, body, error) {
-  var mockedResponse = jest.genMockFunction().mockImplementation(function () {
+  var MockedResponse = jest.genMockFunction().mockImplementation(function () {
     this.status = status;
     this.ok = ok;
     this.body = body;
@@ -59,7 +59,7 @@ function __setResponse (status, ok, body, error) {
     }
   };
 
-  superagent.mockResponse = new mockedResponse();
+  superagent.mockResponse = new MockedResponse();
 }
 
 module.exports = {

src/js/stores/notifications.js

@@ -3,7 +3,6 @@ var _ = require('underscore');
 
 var Reflux = require('reflux');
 var Actions = require('../actions/actions');
-var AuthStore = require('../stores/auth');
 var apiRequests = require('../utils/api-requests');
 
 var NotificationsStore = Reflux.createStore({