Skip to content

Commit 5fcd1de

Browse files
committed
refactor: handler overrides
Signed-off-by: Adam Setch <adam.setch@outlook.com>
1 parent 0386214 commit 5fcd1de

13 files changed

Lines changed: 2 additions & 30 deletions

src/renderer/utils/notifications/handlers/checkSuite.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,6 @@ export interface CheckSuiteAttributes {
3030
}
3131

3232
class CheckSuiteHandler extends DefaultHandler {
33-
override readonly type = 'CheckSuite';
34-
3533
override async enrich(
3634
notification: GitifyNotification,
3735
_settings: SettingsState,

src/renderer/utils/notifications/handlers/commit.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@ import { DefaultHandler } from './default';
1818
import { getNotificationAuthor } from './utils';
1919

2020
class CommitHandler extends DefaultHandler {
21-
override readonly type = 'Commit';
22-
2321
override async enrich(
2422
notification: GitifyNotification,
2523
_settings: SettingsState,

src/renderer/utils/notifications/handlers/default.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,12 @@ import {
99
IconColor,
1010
type Link,
1111
type SettingsState,
12-
type SubjectType,
1312
type UserType,
1413
} from '../../../types';
1514
import type { NotificationTypeHandler } from './types';
1615

1716
export class DefaultHandler implements NotificationTypeHandler {
18-
type?: SubjectType;
19-
20-
supportsMergedQueryEnrichment?: boolean = false;
17+
supportsMergedQueryEnrichment = false;
2118

2219
async enrich(
2320
_notification: GitifyNotification,

src/renderer/utils/notifications/handlers/discussion.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,6 @@ import { DefaultHandler, defaultHandler } from './default';
2929
import { getNotificationAuthor } from './utils';
3030

3131
class DiscussionHandler extends DefaultHandler {
32-
override readonly type = 'Discussion';
33-
3432
override readonly supportsMergedQueryEnrichment = true;
3533

3634
override async enrich(

src/renderer/utils/notifications/handlers/issue.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@ import { DefaultHandler, defaultHandler } from './default';
2323
import { getNotificationAuthor } from './utils';
2424

2525
class IssueHandler extends DefaultHandler {
26-
override readonly type = 'Issue';
27-
2826
override readonly supportsMergedQueryEnrichment = true;
2927

3028
override async enrich(

src/renderer/utils/notifications/handlers/pullRequest.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,6 @@ import { DefaultHandler, defaultHandler } from './default';
2929
import { getNotificationAuthor } from './utils';
3030

3131
class PullRequestHandler extends DefaultHandler {
32-
override readonly type = 'PullRequest' as const;
33-
3432
override readonly supportsMergedQueryEnrichment = true;
3533

3634
override async enrich(

src/renderer/utils/notifications/handlers/release.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,6 @@ import { DefaultHandler, defaultHandler } from './default';
1919
import { getNotificationAuthor } from './utils';
2020

2121
class ReleaseHandler extends DefaultHandler {
22-
override readonly type = 'Release';
23-
2422
override async enrich(
2523
notification: GitifyNotification,
2624
_settings: SettingsState,

src/renderer/utils/notifications/handlers/repositoryAdvisory.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@ import type { GitifyNotification, Link, UserType } from '../../../types';
77
import { DefaultHandler, defaultHandler } from './default';
88

99
class RepositoryAdvisoryHandler extends DefaultHandler {
10-
override readonly type = 'RepositoryAdvisory';
11-
1210
override iconType(_notification: GitifyNotification): FC<OcticonProps> {
1311
return AlertIcon;
1412
}

src/renderer/utils/notifications/handlers/repositoryDependabotAlertsThread.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@ import type { GitifyNotification, Link, UserType } from '../../../types';
88
import { DefaultHandler, defaultHandler } from './default';
99

1010
class RepositoryDependabotAlertsThreadHandler extends DefaultHandler {
11-
override readonly type = 'RepositoryDependabotAlertsThread';
12-
1311
override iconType(_notification: GitifyNotification): FC<OcticonProps> {
1412
return AlertIcon;
1513
}

src/renderer/utils/notifications/handlers/repositoryInvitation.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@ import type { GitifyNotification, Link } from '../../../types';
77
import { DefaultHandler, defaultHandler } from './default';
88

99
class RepositoryInvitationHandler extends DefaultHandler {
10-
override readonly type = 'RepositoryInvitation';
11-
1210
override iconType(_notification: GitifyNotification): FC<OcticonProps> {
1311
return MailIcon;
1412
}

0 commit comments

Comments
 (0)