build: copy static assets in dev

Signed-off-by: Adam Setch <adam.setch@outlook.com>

Author: setchy

.env.template

@@ -1,2 +1,5 @@
 # GitHub Personal Access Token for GraphQL Codegen
-GITHUB_TOKEN=some-pat
+GITHUB_TOKEN=some-pat
+
+# Custom OAuth Client ID for GitHub Device Flow
+#OAUTH_CLIENT_ID=some-client-id

.github/workflows/publish.yml

@@ -68,7 +68,7 @@ jobs:
       - name: Build application
         run: pnpm build
         env:
-          VITE_OAUTH_CLIENT_ID: ${{ secrets.OAUTH_CLIENT_ID }}
+          OAUTH_CLIENT_ID: ${{ secrets.OAUTH_CLIENT_ID }}
 
       - name: Package and publish for ${{ matrix.platform }}
         run: ${{ matrix.package-cmd }}

CONTRIBUTING.md

@@ -10,7 +10,7 @@ We also suggest you read the [Project Philosophy](#project-philosophy) in our do
 > [!TIP]
 > _Optional: If you prefer to use your own OAuth credentials, you can do so by passing them as environment variables when bundling the app. This is optional as the app has some default "development" keys (use at your own discretion)._
 > ```shell
-> VITE_OAUTH_CLIENT_ID="123" pnpm build
+> OAUTH_CLIENT_ID="123" pnpm build
 > ```
 
 To get started:

pnpm-lock.yaml

@@ -57,7 +57,7 @@ export const Constants = {
 
   GITHUB_HOSTNAME: 'github.com' as Hostname,
 
-  OAUTH_DEVICE_FLOW_CLIENT_ID: import.meta.env.VITE_OAUTH_CLIENT_ID as ClientID,
+  OAUTH_DEVICE_FLOW_CLIENT_ID: process.env.OAUTH_CLIENT_ID as ClientID,
 
   // GitHub Enterprise Cloud with Data Residency uses *.ghe.com domains
   GITHUB_ENTERPRISE_CLOUD_DATA_RESIDENCY_HOSTNAME: 'ghe.com',

src/renderer/constants.ts

@@ -176,5 +176,17 @@ export default defineConfig(({ command }) => {
       outDir: fileURLToPath(new URL('build', import.meta.url)),
       emptyOutDir: true,
     },
+    // Define build-time replacements for the main process bundle.
+    // During CI builds `process.env.OAUTH_CLIENT_ID` will be injected via the environment.
+    define: isBuild
+      ? {
+          'process.env.OAUTH_CLIENT_ID': JSON.stringify(
+            process.env.OAUTH_CLIENT_ID ?? '',
+          ),
+        }
+      : {
+          // Development Keys - See CONTRIBUTING.md
+          'process.env.OAUTH_CLIENT_ID': JSON.stringify('Ov23liQIkFs5ehQLNzHF'),
+        },
   };
 });