Skip to content

Commit 817ad09

Browse files
authored
fix: resolve react-is version mismatch and .gitattributes syntax error (#2650)
Override react-is to v19.2.4 via pnpm overrides to fix CounterLabel crash. react-is@18.3.1 checks for Symbol(react.element) but React 19 uses Symbol(react.transitional.element), causing isElement() to return false in @primer/react's ButtonBase and blow up at runtime. Also fix .gitattributes syntax error from stray merge conflict marker.
1 parent 61965fd commit 817ad09

3 files changed

Lines changed: 10 additions & 9 deletions

File tree

.gitattributes

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,4 @@
55
*.snap linguist-generated=true
66

77
# GraphQL Codegen outputs
8-
+ src/renderer/utils/api/graphql/generated/**/*.ts linguist-generated=true
8+
src/renderer/utils/api/graphql/generated/**/*.ts linguist-generated=true

package.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,10 @@
137137
"electron",
138138
"esbuild",
139139
"unrs-resolver"
140-
]
140+
],
141+
"overrides": {
142+
"react-is": "19.2.4"
143+
}
141144
},
142145
"lint-staged": {
143146
"*": "biome check --no-errors-on-unmatched",

pnpm-lock.yaml

Lines changed: 5 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)