fix: resolve strict mode errors in main process

afonsojramos · afonsojramos · commit 8c217ea113d6 · 2026-04-02T04:31:49.000+02:00
diff --git a/src/main/config.test.ts b/src/main/config.test.ts
@@ -33,8 +33,8 @@ describe('main/config.ts', () => {
     expect(WindowConfig.resizable).toBe(false);
     expect(WindowConfig.skipTaskbar).toBe(true);
     expect(WindowConfig.webPreferences).toBeDefined();
-    expect(WindowConfig.webPreferences.contextIsolation).toBe(true);
-    expect(WindowConfig.webPreferences.nodeIntegration).toBe(false);
-    expect(WindowConfig.webPreferences.backgroundThrottling).toBe(false);
+    expect(WindowConfig.webPreferences?.contextIsolation).toBe(true);
+    expect(WindowConfig.webPreferences?.nodeIntegration).toBe(false);
+    expect(WindowConfig.webPreferences?.backgroundThrottling).toBe(false);
   });
 });
diff --git a/src/main/events.ts b/src/main/events.ts
@@ -10,11 +10,11 @@ import type { EventData, EventType } from '../shared/events';
  * @param event - The IPC channel/event name to listen on.
  * @param listener - Callback invoked when the event is received.
  */
-export function onMainEvent(
+export function onMainEvent<T = EventData>(
   event: EventType,
-  listener: (event: Electron.IpcMainEvent, args: EventData) => void,
+  listener: (event: Electron.IpcMainEvent, args: T) => void,
 ) {
-  ipcMain.on(event, listener);
+  ipcMain.on(event, listener as Parameters<typeof ipcMain.on>[1]);
 }
 
 /**
@@ -24,14 +24,14 @@ export function onMainEvent(
  * @param event - The IPC channel/event name to handle.
  * @param listener - Callback whose return value is sent back to the renderer.
  */
-export function handleMainEvent(
+export function handleMainEvent<T = EventData>(
   event: EventType,
   listener: (
     event: Electron.IpcMainInvokeEvent,
-    data: EventData,
+    data: T,
   ) => unknown | Promise<unknown>,
 ) {
-  ipcMain.handle(event, listener);
+  ipcMain.handle(event, listener as Parameters<typeof ipcMain.handle>[1]);
 }
 
 /**
@@ -46,5 +46,5 @@ export function sendRendererEvent(
   event: EventType,
   data?: string,
 ) {
-  mb.window.webContents.send(event, data);
+  mb.window?.webContents.send(event, data);
 }
diff --git a/src/main/handlers/app.test.ts b/src/main/handlers/app.test.ts
@@ -44,10 +44,10 @@ describe('main/handlers/app.ts', () => {
       registerAppHandlers(menubar);
 
       const registeredHandlers = handleMock.mock.calls.map(
-        (call: [string]) => call[0],
+        (call: unknown[]) => call[0],
       );
       const registeredEvents = onMock.mock.calls.map(
-        (call: [string]) => call[0],
+        (call: unknown[]) => call[0],
       );
 
       expect(registeredHandlers).toContain(EVENTS.VERSION);
diff --git a/src/main/handlers/storage.test.ts b/src/main/handlers/storage.test.ts
@@ -29,7 +29,7 @@ describe('main/handlers/storage.ts', () => {
       registerStorageHandlers();
 
       const registeredHandlers = handleMock.mock.calls.map(
-        (call: [string]) => call[0],
+        (call: unknown[]) => call[0],
       );
 
       expect(registeredHandlers).toContain(EVENTS.SAFE_STORAGE_ENCRYPT);
diff --git a/src/main/handlers/storage.ts b/src/main/handlers/storage.ts
@@ -22,11 +22,11 @@ export function registerStorageHandlers(): void {
   handleMainEvent(EVENTS.SAFE_STORAGE_DECRYPT, (_, value: string) => {
     try {
       return safeStorage.decryptString(Buffer.from(value, 'base64'));
-    } catch (err) {
+    } catch (err: unknown) {
       logError(
         'main:safe-storage-decrypt',
         'Failed to decrypt value - data may be from old build',
-        err,
+        err as Error,
       );
       throw err;
     }
diff --git a/src/main/handlers/system.test.ts b/src/main/handlers/system.test.ts
@@ -63,9 +63,9 @@ describe('main/handlers/system.ts', () => {
     it('registers expected system IPC event handlers', () => {
       registerSystemHandlers(menubar);
 
-      const onEvents = onMock.mock.calls.map((call: [string]) => call[0]);
+      const onEvents = onMock.mock.calls.map((call: unknown[]) => call[0]);
       const handleEvents = handleMock.mock.calls.map(
-        (call: [string]) => call[0],
+        (call: unknown[]) => call[0],
       );
 
       expect(onEvents).toContain(EVENTS.OPEN_EXTERNAL);
diff --git a/src/main/handlers/system.ts b/src/main/handlers/system.ts
@@ -24,7 +24,7 @@ export function registerSystemHandlers(mb: Menubar): void {
   let lastRegisteredAccelerator: string | null = null;
 
   const toggleWindow = () => {
-    if (mb.window.isVisible()) {
+    if (mb.window?.isVisible()) {
       mb.hideWindow();
     } else {
       mb.showWindow();
diff --git a/src/main/handlers/tray.test.ts b/src/main/handlers/tray.test.ts
@@ -38,7 +38,7 @@ describe('main/handlers/tray.ts', () => {
       registerTrayHandlers(menubar);
 
       const registeredEvents = onMock.mock.calls.map(
-        (call: [string]) => call[0],
+        (call: unknown[]) => call[0],
       );
 
       expect(registeredEvents).toContain(EVENTS.USE_ALTERNATE_IDLE_ICON);
@@ -55,7 +55,7 @@ describe('main/handlers/tray.ts', () => {
     registerTrayHandlers(menubar);
 
     const updateColorHandler = onMock.mock.calls.find(
-      (call: [string]) => call[0] === EVENTS.UPDATE_ICON_COLOR,
+      (call: unknown[]) => call[0] === EVENTS.UPDATE_ICON_COLOR,
     )?.[1];
     updateColorHandler?.({}, 5);
 
@@ -66,7 +66,7 @@ describe('main/handlers/tray.ts', () => {
     registerTrayHandlers(menubar);
 
     const updateColorHandler = onMock.mock.calls.find(
-      (call: [string]) => call[0] === EVENTS.UPDATE_ICON_COLOR,
+      (call: unknown[]) => call[0] === EVENTS.UPDATE_ICON_COLOR,
     )?.[1];
     updateColorHandler?.({}, 0);
 
@@ -77,7 +77,7 @@ describe('main/handlers/tray.ts', () => {
     registerTrayHandlers(menubar);
 
     const updateColorHandler = onMock.mock.calls.find(
-      (call: [string]) => call[0] === EVENTS.UPDATE_ICON_COLOR,
+      (call: unknown[]) => call[0] === EVENTS.UPDATE_ICON_COLOR,
     )?.[1];
     updateColorHandler?.({}, 3);
 
@@ -88,7 +88,7 @@ describe('main/handlers/tray.ts', () => {
     registerTrayHandlers(menubar);
 
     const updateColorHandler = onMock.mock.calls.find(
-      (call: [string]) => call[0] === EVENTS.UPDATE_ICON_COLOR,
+      (call: unknown[]) => call[0] === EVENTS.UPDATE_ICON_COLOR,
     )?.[1];
     updateColorHandler?.({}, -1);
 
@@ -99,7 +99,7 @@ describe('main/handlers/tray.ts', () => {
     registerTrayHandlers(menubar);
 
     const updateTitleHandler = onMock.mock.calls.find(
-      (call: [string]) => call[0] === EVENTS.UPDATE_ICON_TITLE,
+      (call: unknown[]) => call[0] === EVENTS.UPDATE_ICON_TITLE,
     )?.[1];
     updateTitleHandler?.({}, '5');
 
diff --git a/src/main/lifecycle/first-run.ts b/src/main/lifecycle/first-run.ts
@@ -71,7 +71,11 @@ function checkAndMarkFirstRun(): boolean {
 
     fs.writeFileSync(configPath, '');
   } catch (err) {
-    logError('checkAndMarkFirstRun', 'Unable to write firstRun file', err);
+    logError(
+      'checkAndMarkFirstRun',
+      'Unable to write firstRun file',
+      err as Error,
+    );
   }
 
   return true;
diff --git a/src/main/lifecycle/reset.ts b/src/main/lifecycle/reset.ts
@@ -13,6 +13,10 @@ import { sendRendererEvent } from '../events';
  * @param mb - The menubar instance used for the dialog parent window and quit.
  */
 export function resetApp(mb: Menubar): void {
+  if (!mb.window) {
+    return;
+  }
+
   const cancelButtonId = 0;
   const resetButtonId = 1;
 
diff --git a/src/main/lifecycle/window.test.ts b/src/main/lifecycle/window.test.ts
@@ -37,21 +37,23 @@ describe('main/lifecycle/window.ts', () => {
   it('configureWindowEvents returns early if no window', () => {
     const mbNoWindow = { ...menubar, window: null };
 
-    expect(() => configureWindowEvents(mbNoWindow as Menubar)).not.toThrow();
+    expect(() =>
+      configureWindowEvents(mbNoWindow as unknown as Menubar),
+    ).not.toThrow();
   });
 
   it('configureWindowEvents registers webContents event listeners', () => {
     configureWindowEvents(menubar);
 
-    expect(menubar.window.webContents.on).toHaveBeenCalledWith(
+    expect(menubar.window?.webContents.on).toHaveBeenCalledWith(
       'before-input-event',
       expect.any(Function),
     );
-    expect(menubar.window.webContents.on).toHaveBeenCalledWith(
+    expect(menubar.window?.webContents.on).toHaveBeenCalledWith(
       'devtools-opened',
       expect.any(Function),
     );
-    expect(menubar.window.webContents.on).toHaveBeenCalledWith(
+    expect(menubar.window?.webContents.on).toHaveBeenCalledWith(
       'devtools-closed',
       expect.any(Function),
     );
diff --git a/src/main/lifecycle/window.ts b/src/main/lifecycle/window.ts
@@ -26,19 +26,23 @@ export function configureWindowEvents(mb: Menubar): void {
    * When DevTools is opened, resize and center the window for better visibility and allow resizing.
    */
   mb.window.webContents.on('devtools-opened', () => {
-    mb.window.setSize(800, 600);
-    mb.window.center();
-    mb.window.resizable = true;
-    mb.window.setAlwaysOnTop(true);
+    mb.window?.setSize(800, 600);
+    mb.window?.center();
+    if (mb.window) {
+      mb.window.resizable = true;
+    }
+    mb.window?.setAlwaysOnTop(true);
   });
 
   /**
    * When DevTools is closed, restore the window to its original size and position it centered on the tray icon.
    */
   mb.window.webContents.on('devtools-closed', () => {
     const trayBounds = mb.tray.getBounds();
-    mb.window.setSize(WindowConfig.width, WindowConfig.height);
+    mb.window?.setSize(WindowConfig.width ?? 500, WindowConfig.height ?? 400);
     mb.positioner.move('trayCenter', trayBounds);
-    mb.window.resizable = false;
+    if (mb.window) {
+      mb.window.resizable = false;
+    }
   });
 }
diff --git a/src/main/menu.test.ts b/src/main/menu.test.ts
@@ -200,7 +200,7 @@ describe('main/menu.ts', () => {
       const cfg = getMenuItemConfigByLabel('Check for updates');
       expect(cfg).toBeDefined();
 
-      cfg.click();
+      cfg?.click?.();
 
       expect(autoUpdater.checkForUpdatesAndNotify).toHaveBeenCalled();
     });
@@ -209,7 +209,7 @@ describe('main/menu.ts', () => {
       const cfg = getMenuItemConfigByLabel('Restart to install update');
       expect(cfg).toBeDefined();
 
-      cfg.click();
+      cfg?.click?.();
 
       expect(autoUpdater.quitAndInstall).toHaveBeenCalled();
     });
@@ -220,7 +220,7 @@ describe('main/menu.ts', () => {
         (item) => item?.label === 'Developer',
       ) as TemplateItem;
       expect(devEntry).toBeDefined();
-      const submenu = devEntry.submenu;
+      const submenu = devEntry.submenu ?? [];
       const clickByLabel = (label: string) =>
         submenu.find((i) => i.label === label)?.click?.();
 
@@ -242,15 +242,15 @@ describe('main/menu.ts', () => {
     it('website menu item opens external URL', () => {
       const template = buildAndGetTemplate();
       const item = template.find((i) => i.label === 'Visit Website');
-      item.click();
+      item?.click?.();
       expect(shell.openExternal).toHaveBeenCalledWith(APPLICATION.WEBSITE);
     });
 
     it('quit menu item quits the app', () => {
       const template = buildAndGetTemplate();
       const item = template.find((i) => i.label === `Quit ${APPLICATION.NAME}`);
 
-      item.click();
+      item?.click?.();
 
       expect(menubar.app.quit).toHaveBeenCalled();
     });
@@ -260,7 +260,9 @@ describe('main/menu.ts', () => {
       const devEntry = template.find(
         (item) => item?.label === 'Developer',
       ) as TemplateItem;
-      const reloadItem = devEntry.submenu.find((i) => i.role === 'reload');
+      const reloadItem = (devEntry.submenu ?? []).find(
+        (i) => i.role === 'reload',
+      );
 
       expect(reloadItem?.accelerator).toBe('CommandOrControl+R');
     });
diff --git a/src/main/updater.ts b/src/main/updater.ts
@@ -87,7 +87,7 @@ export default class AppUpdater {
       this.setTooltipWithStatus('A new update is ready to install');
       this.menuBuilder.setUpdateAvailableMenuVisibility(false);
       this.menuBuilder.setUpdateReadyForInstallMenuVisibility(true);
-      this.showUpdateReadyDialog(event.releaseName);
+      this.showUpdateReadyDialog(event.releaseName ?? undefined);
     });
 
     autoUpdater.on('update-not-available', () => {
@@ -196,7 +196,7 @@ export default class AppUpdater {
    *
    * @param releaseName - The version string shown in the dialog message.
    */
-  private showUpdateReadyDialog(releaseName: string) {
+  private showUpdateReadyDialog(releaseName?: string) {
     const dialogOpts: MessageBoxOptions = {
       type: 'info',
       buttons: ['Restart', 'Later'],
diff --git a/src/main/utils.test.ts b/src/main/utils.test.ts
@@ -88,7 +88,7 @@ describe('main/utils', () => {
     });
 
     it('logs error when log path is unavailable', () => {
-      fileGetFileMock.mockReturnValueOnce(null);
+      fileGetFileMock.mockReturnValueOnce(null as unknown as { path: string });
       openLogsDirectory();
       expect(logErrorMock).toHaveBeenCalledWith(
         'openLogsDirectory',
diff --git a/src/main/utils.ts b/src/main/utils.ts
@@ -30,7 +30,7 @@ export function takeScreenshot(mb: Menubar) {
     `${dateStr}-${APPLICATION.NAME}-screenshot.png`,
   );
 
-  mb.window.capturePage().then((img) => {
+  mb.window?.capturePage().then((img) => {
     fs.writeFile(capturedPicFilePath, img.toPNG(), () =>
       logInfo('takeScreenshot', `Screenshot saved ${capturedPicFilePath}`),
     );
