fix: resolve strict mode errors in renderer process

Author: afonsojramos

src/renderer/App.tsx

@@ -26,7 +26,7 @@ import './App.css';
 
 import { useAppContext } from './hooks/useAppContext';
 
-function RequireAuth({ children }) {
+function RequireAuth({ children }: { children: React.ReactNode }) {
   const location = useLocation();
 
   const { isLoggedIn } = useAppContext();

src/renderer/__mocks__/notifications-mocks.ts

@@ -114,7 +114,7 @@ export const mockGitHubCloudGitifyNotifications: GitifyNotification[] = [
       latestCommentUrl:
         'https://api.github.com/repos/gitify-app/notifications-test/issues/comments/302885965' as Link,
       type: 'Issue',
-      reviews: null,
+      reviews: undefined,
     },
     repository: mockGitHubRepository,
     display: {
@@ -168,7 +168,7 @@ export const mockGithubEnterpriseGitifyNotifications: GitifyNotification[] = [
       latestCommentUrl:
         'https://github.gitify.io/api/v3/repos/myorg/notifications-test/releases/3' as Link,
       type: 'Release',
-      reviews: null,
+      reviews: undefined,
     },
     repository: mockEnterpriseRepository,
     display: {
@@ -199,7 +199,7 @@ export const mockGithubEnterpriseGitifyNotifications: GitifyNotification[] = [
       latestCommentUrl:
         'https://github.gitify.io/api/v3/repos/myorg/notifications-test/issues/comments/21' as Link,
       type: 'PullRequest',
-      reviews: null,
+      reviews: undefined,
     },
     repository: mockEnterpriseRepository,
     display: {

src/renderer/components/AllRead.test.tsx

@@ -17,7 +17,7 @@ describe('renderer/components/AllRead.tsx', () => {
       });
     });
 
-    expect(tree.container).toMatchSnapshot();
+    expect(tree!.container).toMatchSnapshot();
   });
 
   it('should render itself & its children - with filters', async () => {
@@ -34,6 +34,6 @@ describe('renderer/components/AllRead.tsx', () => {
       });
     });
 
-    expect(tree.container).toMatchSnapshot();
+    expect(tree!.container).toMatchSnapshot();
   });
 });

src/renderer/components/Oops.test.tsx

@@ -5,6 +5,8 @@ import { PersonIcon } from '@primer/octicons-react';
 
 import { navigateMock, renderWithProviders } from '../__helpers__/test-utils';
 
+import type { GitifyError } from '../types';
+
 import { Oops } from './Oops';
 
 describe('renderer/components/Oops.tsx', () => {
@@ -21,17 +23,19 @@ describe('renderer/components/Oops.tsx', () => {
       tree = renderWithProviders(<Oops error={mockError} />);
     });
 
-    expect(tree.container).toMatchSnapshot();
+    expect(tree!.container).toMatchSnapshot();
   });
 
   it('should render itself & its children - fallback to unknown error', async () => {
     let tree: ReturnType<typeof renderWithProviders> | null = null;
 
     await act(async () => {
-      tree = renderWithProviders(<Oops error={null} />);
+      tree = renderWithProviders(
+        <Oops error={null as unknown as GitifyError} />,
+      );
     });
 
-    expect(tree.container).toMatchSnapshot();
+    expect(tree!.container).toMatchSnapshot();
   });
 
   it('should render action buttons and navigate on click', async () => {

src/renderer/components/avatars/AvatarWithFallback.test.tsx

@@ -32,15 +32,15 @@ describe('renderer/components/avatars/AvatarWithFallback.tsx', () => {
 
   it('renders the fallback icon when no src url - human user', () => {
     const tree = renderWithProviders(
-      <AvatarWithFallback {...props} src={null} />,
+      <AvatarWithFallback {...props} src={undefined} />,
     );
 
     expect(tree.container).toMatchSnapshot();
   });
 
   it('renders the fallback icon when no src url - non human user', () => {
     const tree = renderWithProviders(
-      <AvatarWithFallback {...props} src={null} userType="Bot" />,
+      <AvatarWithFallback {...props} src={undefined} userType="Bot" />,
     );
 
     expect(tree.container).toMatchSnapshot();

src/renderer/components/layout/Centered.tsx

@@ -11,7 +11,7 @@ export const Centered: FC<CenteredProps> = (props: CenteredProps) => {
   return (
     <Stack
       align="center"
-      className={props.fullHeight && 'h-screen'}
+      className={props.fullHeight ? 'h-screen' : undefined}
       direction="vertical"
       justify="center"
       padding="spacious"

src/renderer/components/layout/EmojiSplash.test.tsx

@@ -16,7 +16,7 @@ describe('renderer/components/layout/EmojiSplash.tsx', () => {
       });
     });
 
-    expect(tree.container).toMatchSnapshot();
+    expect(tree!.container).toMatchSnapshot();
   });
 
   it('should render itself & its children - heading and sub-heading', async () => {
@@ -34,6 +34,6 @@ describe('renderer/components/layout/EmojiSplash.tsx', () => {
       });
     });
 
-    expect(tree.container).toMatchSnapshot();
+    expect(tree!.container).toMatchSnapshot();
   });
 });

src/renderer/components/layout/EmojiSplash.tsx

@@ -16,7 +16,7 @@ interface EmojiSplashProps {
 
 export const EmojiSplash: FC<EmojiSplashProps> = (props: EmojiSplashProps) => {
   return (
-    <Centered fullHeight={props.fullHeight}>
+    <Centered fullHeight={props.fullHeight ?? false}>
       <Stack
         align="center"
         direction="vertical"

src/renderer/components/metrics/CommentsPill.test.tsx

@@ -4,7 +4,7 @@ import { CommentsPill, type CommentsPillProps } from './CommentsPill';
 
 describe('renderer/components/metrics/CommentsPill.tsx', () => {
   it('renders with no comments (null)', () => {
-    const props: CommentsPillProps = null;
+    const props = {} as CommentsPillProps;
 
     const tree = renderWithProviders(<CommentsPill {...props} />);
 

src/renderer/components/metrics/MetricGroup.tsx

@@ -37,7 +37,7 @@ export const MetricGroup: FC<MetricGroupProps> = ({ notification }) => {
 
       <CommentsPill commentCount={notification.subject.commentCount ?? 0} />
 
-      <MilestonePill milestone={notification.subject.milestone} />
+      <MilestonePill milestone={notification.subject.milestone!} />
 
       <LabelsPill labels={notification.subject.labels ?? []} />
     </div>