fix: restore null semantics for native notification url parameter

afonsojramos · afonsojramos · commit a2adc75a3a57 · 2026-04-02T19:09:26.000+02:00
diff --git a/src/renderer/utils/system/native.test.ts b/src/renderer/utils/system/native.test.ts
@@ -49,7 +49,7 @@ describe('renderer/utils/system/native.ts', () => {
     expect(window.gitify.raiseNativeNotification).toHaveBeenCalledWith(
       'Gitify',
       'You have 2 notifications',
-      '',
+      undefined,
     );
     expect(url.generateGitHubWebUrl).toHaveBeenCalledTimes(0);
   });
diff --git a/src/renderer/utils/system/native.ts b/src/renderer/utils/system/native.ts
@@ -18,7 +18,7 @@ export async function raiseNativeNotification(
 ) {
   let title: string;
   let body: string;
-  let url = '';
+  let url: string | null = null;
 
   if (notifications.length === 1) {
     const notification = notifications[0];
@@ -32,5 +32,5 @@ export async function raiseNativeNotification(
     body = `You have ${notifications.length} notifications`;
   }
 
-  return window.gitify.raiseNativeNotification(title, body, url);
+  return window.gitify.raiseNativeNotification(title, body, url ?? undefined);
 }

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ export async function raiseNativeNotification(`
`18`	`18`	`) {`
`19`	`19`	`let title: string;`
`20`	`20`	`let body: string;`
`21`		`- let url = '';`
	`21`	`+ let url: string \| null = null;`
`22`	`22`
`23`	`23`	`if (notifications.length === 1) {`
`24`	`24`	`const notification = notifications[0];`
`@@ -32,5 +32,5 @@ export async function raiseNativeNotification(`
`32`	`32`	body = `You have ${notifications.length} notifications`;
`33`	`33`	`}`
`34`	`34`
`35`		`- return window.gitify.raiseNativeNotification(title, body, url);`
	`35`	`+ return window.gitify.raiseNativeNotification(title, body, url ?? undefined);`
`36`	`36`	`}`