remove unused callback for github app oauth web flow

Signed-off-by: Adam Setch <adam.setch@outlook.com>

Author: setchy

src/renderer/__helpers__/jest.setup.ts

@@ -70,3 +70,11 @@ globalThis.matchMedia = (query: string): MediaQueryList => ({
   removeEventListener: () => {},
   dispatchEvent: () => false,
 });
+
+Object.defineProperty(navigator, 'clipboard', {
+  value: {
+    writeText: jest.fn().mockResolvedValue(undefined),
+    readText: jest.fn().mockResolvedValue(''),
+  },
+  configurable: true,
+});

src/renderer/utils/auth/types.ts

@@ -34,6 +34,12 @@ export interface DeviceFlowSession {
   expiresAt: number;
 }
 
+export type DeviceFlowErrorResponse = {
+  error: string;
+  error_description: string;
+  error_uri: string;
+};
+
 export interface LoginPersonalAccessTokenOptions {
   hostname: Hostname;
   token: Token;

src/renderer/utils/auth/utils.ts

@@ -5,6 +5,7 @@ import {
   getWebFlowAuthorizationUrl,
 } from '@octokit/oauth-methods';
 import { request } from '@octokit/request';
+import { RequestError } from '@octokit/request-error';
 
 import { format } from 'date-fns';
 import semver from 'semver';
@@ -26,6 +27,7 @@ import type {
 import type {
   AuthMethod,
   AuthResponse,
+  DeviceFlowErrorResponse,
   DeviceFlowSession,
   LoginOAuthDeviceOptions,
   LoginOAuthWebOptions,
@@ -124,13 +126,21 @@ export async function pollGitHubDeviceFlow(
 
     return authentication.token as Token;
   } catch (err) {
-    const errorCode = (err as { response?: { data?: { error?: string } } })
-      ?.response?.data?.error;
+    if (err instanceof RequestError) {
+      const response = err.response.data as DeviceFlowErrorResponse;
+      const errorCode = response.error;
 
-    if (errorCode === 'authorization_pending' || errorCode === 'slow_down') {
-      return null;
+      if (errorCode === 'authorization_pending' || errorCode === 'slow_down') {
+        return null;
+      }
     }
 
+    rendererLogError(
+      'pollGitHubDeviceFlow',
+      'Error exchanging device code',
+      err,
+    );
+
     throw err;
   }
 }

src/renderer/utils/comms.test.ts

@@ -3,6 +3,7 @@ import { mockSettings } from '../__mocks__/state-mocks';
 import { type Link, OpenPreference } from '../types';
 
 import {
+  copyToClipboard,
   decryptValue,
   encryptValue,
   getAppVersion,
@@ -156,4 +157,11 @@ describe('renderer/utils/comms.ts', () => {
       expect(window.gitify.tray.updateTitle).toHaveBeenCalledWith('gitify');
     });
   });
+
+  it('copy to clipboard', async () => {
+    copyToClipboard('some-value');
+
+    expect(navigator.clipboard.writeText).toHaveBeenCalledTimes(1);
+    expect(navigator.clipboard.writeText).toHaveBeenCalledWith('some-value');
+  });
 });

src/renderer/utils/comms.ts

@@ -50,9 +50,7 @@ export function setAutoLaunch(value: boolean): void {
 export function setUseAlternateIdleIcon(value: boolean): void {
   window.gitify.tray.useAlternateIdleIcon(value);
 }
-export async function copyToClipboard(text: string): Promise<void> {
-  await navigator.clipboard.writeText(text);
-}
+
 export function setUseUnreadActiveIcon(value: boolean): void {
   window.gitify.tray.useUnreadActiveIcon(value);
 }
@@ -80,3 +78,7 @@ export function updateTrayColor(notificationsLength: number): void {
 export function updateTrayTitle(title: string): void {
   window.gitify.tray.updateTitle(title);
 }
+
+export async function copyToClipboard(text: string): Promise<void> {
+  await navigator.clipboard.writeText(text);
+}