remove axios test helper

Signed-off-by: Adam Setch <adam.setch@outlook.com>

Author: setchy

src/renderer/__helpers__/test-utils.tsx

@@ -21,10 +21,7 @@ interface AppContextProviderProps {
  * Wrapper component that provides ThemeProvider, BaseStyles, and AppContext
  * with sensible defaults for testing.
  */
-export function AppContextProvider({
-  children,
-  value = {},
-}: AppContextProviderProps) {
+function AppContextProvider({ children, value = {} }: AppContextProviderProps) {
   const defaultValue: AppContextState = useMemo(() => {
     return {
       auth: mockAuth,
@@ -96,13 +93,3 @@ export function renderWithAppContext(
 export function ensureStableEmojis() {
   globalThis.Math.random = jest.fn(() => 0.1);
 }
-
-/**
- * Configure HTTP mocking for tests that use nock.
- *
- * Octokit uses @octokit/request which is compatible with nock's HTTP interception.
- * No special configuration is needed.
- */
-export function configureAxiosHttpAdapterForNock() {
-  // No-op: Octokit's @octokit/request works with nock by default
-}

src/renderer/hooks/useNotifications.test.ts

@@ -2,10 +2,7 @@ import { act, renderHook, waitFor } from '@testing-library/react';
 
 import nock from 'nock';
 
-import {
-  configureAxiosHttpAdapterForNock,
-  type DeepPartial,
-} from '../__helpers__/test-utils';
+import type { DeepPartial } from '../__helpers__/test-utils';
 import {
   mockGitHubCloudAccount,
   mockGitHubEnterpriseServerAccount,
@@ -35,10 +32,9 @@ describe('renderer/hooks/useNotifications.ts', () => {
     .mockImplementation();
 
   beforeEach(() => {
-    configureAxiosHttpAdapterForNock();
-
     jest.clearAllMocks();
     // Reset mock notification state between tests since it's mutated
+    // FIXME - isolate test data between tests
     mockGitifyNotification.unread = true;
   });
 

src/renderer/utils/auth/utils.test.ts

@@ -1,4 +1,3 @@
-import { configureAxiosHttpAdapterForNock } from '../../__helpers__/test-utils';
 import { mockGitHubCloudAccount } from '../../__mocks__/account-mocks';
 import { mockAuth } from '../../__mocks__/state-mocks';
 
@@ -32,10 +31,6 @@ const exchangeWebFlowCodeMock = exchangeWebFlowCode as jest.MockedFunction<
 >;
 
 describe('renderer/utils/auth/utils.ts', () => {
-  beforeEach(() => {
-    configureAxiosHttpAdapterForNock();
-  });
-
   describe('authGitHub', () => {
     jest.spyOn(logger, 'rendererLogInfo').mockImplementation();
     const openExternalLinkSpy = jest

src/renderer/utils/notifications/handlers/commit.test.ts

@@ -1,6 +1,5 @@
 import nock from 'nock';
 
-import { configureAxiosHttpAdapterForNock } from '../../../__helpers__/test-utils';
 import { mockPartialGitifyNotification } from '../../../__mocks__/notifications-mocks';
 import { mockSettings } from '../../../__mocks__/state-mocks';
 import { mockRawUser } from '../../api/__mocks__/response-mocks';
@@ -14,10 +13,6 @@ import type {
 import { commitHandler } from './commit';
 
 describe('renderer/utils/notifications/handlers/commit.ts', () => {
-  beforeEach(() => {
-    configureAxiosHttpAdapterForNock();
-  });
-
   describe('enrich', () => {
     const mockAuthor = mockRawUser('some-author');
     const mockCommenter = mockRawUser('some-commenter');

src/renderer/utils/notifications/handlers/discussion.test.ts

@@ -1,6 +1,5 @@
 import nock from 'nock';
 
-import { configureAxiosHttpAdapterForNock } from '../../../__helpers__/test-utils';
 import { mockPartialGitifyNotification } from '../../../__mocks__/notifications-mocks';
 import { mockSettings } from '../../../__mocks__/state-mocks';
 import {
@@ -22,10 +21,6 @@ import type { FetchDiscussionByNumberQuery } from '../../api/graphql/generated/g
 import { discussionHandler } from './discussion';
 
 describe('renderer/utils/notifications/handlers/discussion.ts', () => {
-  beforeEach(() => {
-    configureAxiosHttpAdapterForNock();
-  });
-
   describe('supportsMergedQueryEnrichment', () => {
     it('should support merge query', () => {
       expect(discussionHandler.supportsMergedQueryEnrichment).toBeTruthy();

src/renderer/utils/notifications/handlers/issue.test.ts

@@ -1,6 +1,5 @@
 import nock from 'nock';
 
-import { configureAxiosHttpAdapterForNock } from '../../../__helpers__/test-utils';
 import { mockPartialGitifyNotification } from '../../../__mocks__/notifications-mocks';
 import { mockSettings } from '../../../__mocks__/state-mocks';
 import {
@@ -21,10 +20,6 @@ import type { FetchIssueByNumberQuery } from '../../api/graphql/generated/graphq
 import { issueHandler } from './issue';
 
 describe('renderer/utils/notifications/handlers/issue.ts', () => {
-  beforeEach(() => {
-    configureAxiosHttpAdapterForNock();
-  });
-
   describe('supportsMergedQueryEnrichment', () => {
     it('should support merge query', () => {
       expect(issueHandler.supportsMergedQueryEnrichment).toBeTruthy();

src/renderer/utils/notifications/handlers/pullRequest.test.ts

@@ -1,6 +1,5 @@
 import nock from 'nock';
 
-import { configureAxiosHttpAdapterForNock } from '../../../__helpers__/test-utils';
 import { mockPartialGitifyNotification } from '../../../__mocks__/notifications-mocks';
 import { mockSettings } from '../../../__mocks__/state-mocks';
 import {
@@ -24,10 +23,6 @@ import type {
 import { getLatestReviewForReviewers, pullRequestHandler } from './pullRequest';
 
 describe('renderer/utils/notifications/handlers/pullRequest.ts', () => {
-  beforeEach(() => {
-    configureAxiosHttpAdapterForNock();
-  });
-
   describe('mergeQueryConfig', () => {
     describe('supportsMergedQueryEnrichment', () => {
       it('should support merge query', () => {

src/renderer/utils/notifications/handlers/release.test.ts

@@ -1,6 +1,5 @@
 import nock from 'nock';
 
-import { configureAxiosHttpAdapterForNock } from '../../../__helpers__/test-utils';
 import { mockPartialGitifyNotification } from '../../../__mocks__/notifications-mocks';
 import { mockSettings } from '../../../__mocks__/state-mocks';
 import { mockRawUser } from '../../api/__mocks__/response-mocks';
@@ -19,10 +18,6 @@ describe('renderer/utils/notifications/handlers/release.ts', () => {
       'https://api.github.com/repos/gitify-app/notifications-test/releases/1' as Link,
   });
 
-  beforeEach(() => {
-    configureAxiosHttpAdapterForNock();
-  });
-
   describe('enrich', () => {
     const mockAuthor = mockRawUser('some-author');
 

src/renderer/utils/notifications/notifications.test.ts

@@ -1,6 +1,5 @@
 import nock from 'nock';
 
-import { configureAxiosHttpAdapterForNock } from '../../__helpers__/test-utils';
 import {
   mockGitHubCloudAccount,
   mockGitHubEnterpriseServerAccount,
@@ -34,10 +33,6 @@ import {
 } from './notifications';
 
 describe('renderer/utils/notifications/notifications.ts', () => {
-  beforeEach(() => {
-    configureAxiosHttpAdapterForNock();
-  });
-
   afterEach(() => {
     jest.clearAllMocks();
   });