Skip to content

author: exclude filter suppresses review_requested notifications on matching PRs #2914

@rcdailey

Description

@rcdailey

🔍 Is there already an issue for your problem?

  • I have checked older issues, open and closed

📝 Description

When using the search filter with author:somebot as an exclude term, notifications with reason review_requested are hidden if the bot is resolved as the notification's subject.user during enrichment, even when the bot did not open the PR.

I have org:myorg as an include filter and author:coderabbitai as an exclude filter. A coworker requests my review on a human-authored PR. CodeRabbit automatically comments on the PR (as bots do). Since the enrichment handler fetches only the last comment (LAST_COMMENTS: 1 in constants.ts), and pullRequest.ts prioritizes the last comment's author over the PR author when setting subject.user:

const prComment = pr.comments?.nodes?.[0];
const prUser = getNotificationAuthor([prComment?.author, pr.author]);

...subject.user.login becomes coderabbitai. The exclude filter then matches and the notification is filtered out, even though:

  1. The PR was opened by a human
  2. The notification reason is review_requested (someone directly asked for my review)
  3. CodeRabbit's only involvement was leaving an automated comment

The author: qualifier in search.ts extracts n.subject?.user?.login unconditionally, and filter.ts applies the exclude without considering notification.reason. This means you can't filter out bot comment noise without also losing actionable review requests, assignments, and mentions on any PR where the bot happened to leave the last comment.

🪜 Steps To Reproduce

  1. Enable detailed notifications in settings
  2. Add an include search filter: org:<your-org>
  3. Add an exclude search filter: author:<some-bot> (e.g. author:coderabbitai)
  4. Have a human open a PR in the org where the bot automatically comments
  5. Have someone request your review on that PR
  6. The "review requested" notification appears on github.com/notifications but not in Gitify

🪵 Log Excerpts

No response

Gitify Version

6.17.0

Operating System

macOS

GitHub Account

GitHub Cloud

📸 Screenshots

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    priority:lowItems of low importance. Applicable to select few users or use-cases

    Priority

    None yet

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions