fix(renovate): use changelogUrl instead of deprecated sourceUrl#2485
fix(renovate): use changelogUrl instead of deprecated sourceUrl#2485
Conversation
Add rate limiting, grouping, and minimum release age to reduce PR volume while maintaining weekly updates. Groups related packages (electron, react, testing, build tools) to batch dependency updates.
| "rangeStrategy": "pin", | ||
| "prConcurrentLimit": 3, | ||
| "prHourlyLimit": 2, | ||
| "minimumReleaseAge": "3 days", |
There was a problem hiding this comment.
This is part of the best-practices preset we extend
| "description": "Fetch changelog details for twemoji packages", | ||
| "matchPackageNames": ["@discordapp/twemoji"], | ||
| "sourceUrl": "https://github.com/jdjdecked/twemoji" | ||
| "changelogUrl": "https://github.com/jdjdecked/twemoji" |
There was a problem hiding this comment.
Good catch - the next major release of renovate would have auto migrate this config
|
I have an alternate approach, which I'll propose as a separate PR, that uses the Renovate Dependency Dashboard approval workflow. This should help some of your concerns. As for the rate limiting and grouping suggestions, I do not want to go down this path... I much prefer having each update as a separate PR (as-is now), since it's then explicitly referenced in the autogenerated release notes without having to deep dive into each PRs contents. I believe the Approval Dashboard workflow will also help in this regard |
|
Copied the config from renovatebot/.gitthub/default.json - it's the same workflow they use for their project |
| "groupName": "graphql" | ||
| }, | ||
| { | ||
| "description": "Group remaining non-major npm updates not covered by specific groups", |
There was a problem hiding this comment.
This could be done by using the preset "group:allNonMajor"
https://docs.renovatebot.com/presets-group/#groupallnonmajor
afonsojramos
force-pushed
the
renovate-config-optimization
branch
from
ae547af to
7a7a119
Compare
afonsojramos
changed the title
github-actions
Bot
added
bug
|
@setchy I understand that perspective, but given that only when we release/are about to are these changes shipped, wouldn't it make sense to only merge these kinds of PRs then (excluding majors)? |
2 participants
Summary
Fix deprecated
sourceUrlfield in twemoji rule by replacing it withchangelogUrl.Changes
sourceUrlwithchangelogUrlfor twemoji package rule (Renovate deprecatedsourceUrl)Thanks @setchy for the feedback on the original PR - I've reduced the scope to just this fix since PR #2486 addressed the notification concerns via the Dependency Dashboard approval workflow.