Fixes similarity threshold ignored in Git status

`getStatus` and `getStatusForPathCore` called `statusCore` without a
similarity threshold, so `--find-renames` fell back to Git's default 50%
instead of the configured `gitlens.advanced.similarityThreshold`. Forwards
`context.config.commits.similarityThreshold` to both call sites. Regression
from the standalone-packages refactor.

Author: ianhattendorf

CHANGELOG.md

@@ -46,6 +46,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/) and this p
 ### Fixed
 
 - Fixes opening the _Commit Graph_ in multi root workspace to the correct repo ([#5276](https://github.com/gitkraken/vscode-gitlens/issues/5276))
+- Fixes the `gitlens.advanced.similarityThreshold` setting being ignored when computing Git status — rename detection in status, working changes (WIP), and stash file lists used Git's default threshold (50%) instead of the configured value
 - Fixes the `gitlens.advanced.similarityThreshold` setting being ignored when listing changed files for a diff — rename detection used Git's default threshold (50%) instead of the configured value
 - Fixes force push from the _Push_ command always using `--force-with-lease` (and `--force-if-includes`) and ignoring VS Code's `git.useForcePushWithLease` and `git.useForcePushIfIncludes` settings — the confirmation could offer a plain `--force` while GitLens still pushed with lease; it now honors the configured preference
 - Fixes _Stash Unstaged Changes_ also stashing staged changes when an untracked file is involved — including untracked files no longer drops the `--keep-index` flag, so staged changes are correctly kept intact ([#5281](https://github.com/gitkraken/vscode-gitlens/issues/5281))

packages/git-cli/src/providers/status.ts

@@ -43,7 +43,15 @@ export class StatusGitSubProvider implements GitStatusSubProvider {
 
 		const porcelainVersion = (await this.git.supports('git:status:porcelain-v2')) ? 2 : 1;
 
-		const result = await this.statusCore(repoPath, porcelainVersion, { priority: options?.priority }, cancellation);
+		const result = await this.statusCore(
+			repoPath,
+			porcelainVersion,
+			{
+				similarityThreshold: this.context.config?.commits.similarityThreshold,
+				priority: options?.priority,
+			},
+			cancellation,
+		);
 		const repoUri = fileUri(normalizePath(repoPath));
 		const status = parseGitStatus(result.stdout, repoPath, porcelainVersion, p =>
 			joinUriPath(repoUri, normalizePath(p)),
@@ -111,7 +119,7 @@ export class StatusGitSubProvider implements GitStatusSubProvider {
 		const result = await this.statusCore(
 			repoPath,
 			porcelainVersion,
-			{},
+			{ similarityThreshold: this.context.config?.commits.similarityThreshold },
 			cancellation,
 			// If we want renames, don't include the path as Git won't do rename detection
 			...(renames ? [] : [relativePath]),
@@ -135,7 +143,7 @@ export class StatusGitSubProvider implements GitStatusSubProvider {
 	private async statusCore(
 		repoPath: string,
 		porcelainVersion: number = 1,
-		options?: { similarityThreshold?: number; priority?: GitCommandPriority },
+		options?: { similarityThreshold?: number | null; priority?: GitCommandPriority },
 		cancellation?: AbortSignal,
 		...pathspecs: string[]
 	): Promise<GitResult> {