Skip to content

Commit ce1f70e

Browse files
committed
Disable no-return-await rule in ESLint configuration and remove unnecessary comment in runCLICommand function
(#5092, gitkraken/vscode-gitlens-private#78)
1 parent a3fef37 commit ce1f70e

2 files changed

Lines changed: 1 addition & 2 deletions

File tree

eslint.config.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,7 @@ export default defineConfig(
218218
'no-restricted-globals': ['error', 'process'],
219219
'no-restricted-imports': 'off',
220220
'no-return-assign': 'error',
221-
'no-return-await': 'warn',
221+
'no-return-await': 'off', // Disabled in favor of @typescript-eslint/return-await (handles `using` correctly)
222222
'no-self-compare': 'error',
223223
'no-sequences': 'error',
224224
'no-template-curly-in-string': 'warn',

src/env/node/gk/cli/utils.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,6 @@ export async function runCLICommand(args: string[], options?: { cwd?: string }):
118118
throw new Error('CLI is not installed');
119119
}
120120

121-
// eslint-disable-next-line no-return-await -- await is needed for the scope to be properly disposed
122121
return await run(command, args, 'utf8', { cwd: cwd });
123122
}
124123

0 commit comments

Comments
 (0)