Fixes GitKraken AI model selection showing 'No models found' - fixes #4963

- Removes silent error swallowing in GitKrakenProvider.getModels() — errors now propagate so callers can handle them
- Checks for a valid auth token (getApiKey) before making the API request, returning [] early if unauthenticated
- Passes the access token explicitly to getGkHeaders() instead of relying on the internal lookup that threw AuthenticationRequiredError silently
- Adds null guard for result.data to handle missing/null API response fields
- Removes leftover debugger statement
- Catches getModels() errors in showAIModelPicker and shows 'Unable to load models' with the error description instead of the generic 'No models found'
- Adds defensive try/catch in getOrUpdateModel for getModels() call used to restore a previously configured model

Author: shoaib-fixes

CHANGELOG.md

@@ -12,6 +12,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/) and this p
 
 ### Fixed
 
+- Fixes _GitKraken AI_ model selection showing 'No models found' when switching AI provider/model ([#4963](https://github.com/gitkraken/vscode-gitlens/issues/4963))
 - Fixes provider id mismatch for cloud-connected self-hosted integrations ([#5031](https://github.com/gitkraken/vscode-gitlens/issues/5031))
 - Fixes an issue where the _Launchpad_ would fail to show any pull requests when one integration provider had an authentication failure — now shows partial results with an error indicator ([#4492](https://github.com/gitkraken/vscode-gitlens/issues/4492))
 

src/plus/ai/aiProviderService.ts

@@ -561,7 +561,10 @@ export class AIProviderService implements AIService, Disposable {
 			} else {
 				changed = true;
 
-				const models = await this._provider.getModels();
+				let models: readonly AIModel[] | undefined;
+				try {
+					models = await this._provider.getModels();
+				} catch {}
 				model = models?.find(m => m.id === modelId);
 				if (model == null) {
 					this._model = undefined;

src/plus/ai/gitkrakenProvider.ts

@@ -32,55 +32,53 @@ export class GitKrakenProvider extends OpenAICompatibleProviderBase<typeof provi
 	async getModels(): Promise<readonly AIModel<typeof provider.id>[]> {
 		const scope = getScopedLogger();
 
-		try {
-			const url = this.container.urls.getGkAIApiUrl('providers/message-prompt');
-			const rsp = await fetch(url, {
-				headers: await this.connection.getGkHeaders(undefined, undefined, {
-					Accept: 'application/json',
-				}),
-			});
-			if (!rsp.ok) {
-				throw new Error(`Getting models (${url}) failed: ${rsp.status} (${rsp.statusText})`);
-			}
-
-			interface ModelsResponse {
-				data: {
-					providerId: string;
-					providerName: string;
-					modelId: string;
-					modelName: string;
-					preferred: boolean;
-					maxInputTokens: number;
-					maxOutputTokens: number;
-				}[];
-				error?: null;
-			}
-
-			const result: ModelsResponse = await rsp.json();
-			if (result.error != null) {
-				throw new Error(`Getting models (${url}) failed: ${String(result.error)}`);
-			}
-
-			const models = result.data.map<GitKrakenModel>(
-				m =>
-					({
-						id: m.modelId,
-						name: m.modelName,
-						maxTokens: { input: m.maxInputTokens, output: m.maxOutputTokens },
-						provider: provider,
-						default: m.preferred,
-						temperature: null,
-					}) satisfies GitKrakenModel,
-			);
-			return models;
-		} catch (ex) {
-			if (!(ex instanceof AuthenticationRequiredError)) {
-				debugger;
-				scope?.error(ex, `Unable to get models`);
-			}
+		const apiKey = await this.getApiKey(true);
+		if (!apiKey) return [];
+
+		const url = this.container.urls.getGkAIApiUrl('providers/message-prompt');
+		const rsp = await fetch(url, {
+			headers: await this.connection.getGkHeaders(apiKey, undefined, {
+				Accept: 'application/json',
+			}),
+		});
+		if (!rsp.ok) {
+			scope?.error(undefined, `Getting models (${url}) failed: ${rsp.status} (${rsp.statusText})`);
+			throw new Error(`Getting models failed: (${rsp.status}) ${rsp.statusText}`);
+		}
+
+		interface ModelsResponse {
+			data: {
+				providerId: string;
+				providerName: string;
+				modelId: string;
+				modelName: string;
+				preferred: boolean;
+				maxInputTokens: number;
+				maxOutputTokens: number;
+			}[];
+			error?: null;
+		}
+
+		const result: ModelsResponse = await rsp.json();
+		if (result.error != null) {
+			scope?.error(undefined, `Getting models (${url}) failed: ${String(result.error)}`);
+			throw new Error(`Getting models failed: ${String(result.error)}`);
 		}
 
-		return [];
+		if (!result.data) return [];
+
+		const models = result.data.map<GitKrakenModel>(
+			m =>
+				({
+					id: m.modelId,
+					name: m.modelName,
+					maxTokens: { input: m.maxInputTokens, output: m.maxOutputTokens },
+					provider: provider,
+					default: m.preferred,
+					temperature: null,
+				}) satisfies GitKrakenModel,
+		);
+		return models;
 	}
 
 	protected getUrl(_model: AIModel<typeof provider.id>): string {

src/quickpicks/aiModelPicker.ts

@@ -136,15 +136,25 @@ export async function showAIModelPicker(
 ): Promise<ModelQuickPickItem | Directive | undefined> {
 	if (!(await ensureAccess(container, { showPicker: true }, source))) return undefined;
 
-	const models = (await container.ai.getModels(provider)) ?? [];
+	let models: readonly AIModel[];
+	let modelsError: string | undefined;
+	try {
+		models = (await container.ai.getModels(provider)) ?? [];
+	} catch (ex) {
+		models = [];
+		modelsError = ex instanceof Error ? ex.message : String(ex);
+	}
 
 	const items: Array<ModelQuickPickItem | DirectiveQuickPickItem> = [];
 
 	if (!models.length) {
 		items.push({
-			label: 'No models found',
-			description:
-				provider === 'ollama' ? 'Please install a model or check your Ollama server configuration' : undefined,
+			label: modelsError ? 'Unable to load models' : 'No models found',
+			description: modelsError
+				? modelsError
+				: provider === 'ollama'
+					? 'Please install a model or check your Ollama server configuration'
+					: undefined,
 			iconPath: new ThemeIcon('error'),
 			directive: Directive.Noop,
 		} satisfies ModelQuickPickItem | DirectiveQuickPickItem);