Skip to content

Commit f6bff9c

Browse files
ash2kEmmanuel326
authored andcommitted
Merge branch 'runner-wrapper-errch-buffer' into 'main'
runner-wrapper: buffer errCh to avoid goroutine leak on shutdown See merge request https://gitlab.com/gitlab-org/gitlab-runner/-/merge_requests/6337 Merged-by: Mikhail Mazurskiy <mmazurskiy@gitlab.com> Approved-by: Mikhail Mazurskiy <mmazurskiy@gitlab.com> Co-authored-by: Emmanuel326 <nyariboemmanuel8@gmail.com>
2 parents f9b8858 + 31c801f commit f6bff9c

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

helpers/runner_wrapper/wrapper.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ func New(log logrus.FieldLogger, path string, args []string) *Wrapper {
4949
log: log,
5050
path: path,
5151
args: args,
52-
errCh: make(chan error),
52+
errCh: make(chan error, 1),
5353
terminationTimeout: DefaultTerminationTimeout,
5454
status: api.StatusUnknown,
5555
commanderFactory: newDefaultCommander,

0 commit comments

Comments
 (0)