Skip to content

Commit 4346614

Browse files
author
Rafał Hibner
committed
Merge branch 'SerialSequencingBackpressure' into combined2
2 parents 3597a00 + d918742 commit 4346614

1 file changed

Lines changed: 7 additions & 2 deletions

File tree

cpp/src/arrow/acero/accumulation_queue.h

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ class ARROW_ACERO_EXPORT SequencingQueue {
127127
class ARROW_ACERO_EXPORT SerialSequencingQueue {
128128
public:
129129
/// Strategy that describes how to handle items
130-
class Processor {
130+
class ARROW_ACERO_EXPORT Processor {
131131
public:
132132
virtual ~Processor() = default;
133133
/// Process the batch
@@ -142,10 +142,15 @@ class ARROW_ACERO_EXPORT SerialSequencingQueue {
142142
/// be pretty fast and so are unlikely to block.
143143
virtual Status Process(ExecBatch batch) = 0;
144144

145+
/// Wrapper for processor with backpressure
146+
///
147+
/// This wrapper adds backpressure logic acting on number of sequenced batches.
148+
// Also batches are Processes on new scheduled tasks. The tasks will be scheduled on
149+
/// IO executor when requires_io==true.
145150
static std::unique_ptr<Processor> MakeBackpressureWrapper(Processor* processor,
146151
BackpressureHandler handler,
147152
ExecPlan* plan,
148-
bool requires_io = true);
153+
bool requires_io = false);
149154
};
150155

151156
virtual ~SerialSequencingQueue() = default;

0 commit comments

Comments
 (0)