Merge branch 'writer_test' into combined2

Author: Rafał Hibner

cpp/src/arrow/dataset/dataset_writer.cc

@@ -22,7 +22,6 @@
 #include <mutex>
 #include <unordered_map>
 #include <unordered_set>
-#include <iostream>
 
 #include "arrow/filesystem/path_util.h"
 #include "arrow/record_batch.h"

cpp/src/arrow/dataset/dataset_writer_test.cc

@@ -20,9 +20,8 @@
 #include <chrono>
 #include <mutex>
 #include <optional>
-#include <vector>
-#include <random>
 #include <thread>
+#include <vector>
 
 #include "arrow/array/builder_primitive.h"
 #include "arrow/dataset/file_ipc.h"
@@ -277,38 +276,37 @@ TEST_F(DatasetWriterTestFixture, BatchGreaterThanMaxRowsQueued) {
   ASSERT_EQ(paused_, false);
 }
 
-#pragma GCC push_options
-#pragma GCC optimize ("O0")
 TEST_F(DatasetWriterTestFixture, BatchWriteConcurrent) {
   auto dataset_writer = MakeDatasetWriter(/*max_rows=*/5);
 
-
-  for(int threads=1;threads<5;threads++){
-    for(int iter=2;iter<=256;iter*=2){
-      for(int batch=2;batch<=64;batch*=2){
+  for (int threads = 1; threads < 5; threads++) {
+    for (int iter = 2; iter <= 256; iter *= 2) {
+      for (int batch = 2; batch <= 64; batch *= 2) {
         std::vector<std::thread> workers;
-        for(int i=0;i<threads;++i){
-          workers.push_back(std::thread(
-          [&,i=i](){
-            for(int j=0;j<iter;++j){
-              while(paused_){SleepABit();};
-              dataset_writer->WriteRecordBatch(MakeBatch(batch+i+10*j), "");
+        for (int i = 0; i < threads; ++i) {
+          workers.push_back(std::thread([&, i = i]() {
+            for (int j = 0; j < iter; ++j) {
+              while (paused_) {
+                SleepABit();
+              }
+              dataset_writer->WriteRecordBatch(MakeBatch(batch + i + 10 * j), "");
             }
           }));
         }
-        for (std::thread &t: workers) {
+        for (std::thread& t : workers) {
           if (t.joinable()) {
             t.join();
           }
-          while(paused_){SleepABit();};
+          while (paused_) {
+            SleepABit();
+          }
         }
       }
     }
   }
   EndWriterChecked(dataset_writer.get());
   ASSERT_EQ(paused_, false);
 }
-#pragma GCC pop_options
 
 TEST_F(DatasetWriterTestFixture, MaxRowsOneWrite) {
   write_options_.max_rows_per_file = 10;