Skip to content

Commit 5b02fe5

Browse files
feat(api): remove Terminal field from RunsOn type
1 parent c2e999e commit 5b02fe5

5 files changed

Lines changed: 9 additions & 22 deletions

File tree

.stats.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
configured_endpoints: 193
2-
openapi_spec_url: https://storage.googleapis.com/stainless-sdk-openapi-specs/gitpod%2Fgitpod-9b7fd2030480921db661aeb8eb6c454e8b53accf4bddecc66e740383ab7ad074.yml
3-
openapi_spec_hash: deb597c2dbac0fddcdd136aae19aba44
2+
openapi_spec_url: https://storage.googleapis.com/stainless-sdk-openapi-specs/gitpod%2Fgitpod-ffc8cf0ed565636356f70cba5521094ee367d0b30bacb266a70f4ea98889c74c.yml
3+
openapi_spec_hash: bf1abc17445dd410c3c3f8607c5a4937
44
config_hash: 843d5f356bfb6295862722a8d71d08e0

environmentautomation_test.go

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,7 @@ func TestEnvironmentAutomationUpsertWithOptionalParams(t *testing.T) {
4444
Environment: gitpod.F([]string{"string"}),
4545
Image: gitpod.F("x"),
4646
}),
47-
Machine: gitpod.F[any](map[string]interface{}{}),
48-
Terminal: gitpod.F[any](map[string]interface{}{}),
47+
Machine: gitpod.F[any](map[string]interface{}{}),
4948
}),
5049
TriggeredBy: gitpod.F([]gitpod.AutomationsFileServicesTriggeredBy{gitpod.AutomationsFileServicesTriggeredByPostDevcontainerStart}),
5150
},
@@ -61,8 +60,7 @@ func TestEnvironmentAutomationUpsertWithOptionalParams(t *testing.T) {
6160
Environment: gitpod.F([]string{"string"}),
6261
Image: gitpod.F("x"),
6362
}),
64-
Machine: gitpod.F[any](map[string]interface{}{}),
65-
Terminal: gitpod.F[any](map[string]interface{}{}),
63+
Machine: gitpod.F[any](map[string]interface{}{}),
6664
}),
6765
TriggeredBy: gitpod.F([]gitpod.AutomationsFileTasksTriggeredBy{gitpod.AutomationsFileTasksTriggeredByPostEnvironmentStart}),
6866
},

environmentautomationservice_test.go

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,7 @@ func TestEnvironmentAutomationServiceNewWithOptionalParams(t *testing.T) {
7070
Environment: gitpod.F([]string{"string"}),
7171
Image: gitpod.F("x"),
7272
}),
73-
Machine: gitpod.F[any](map[string]interface{}{}),
74-
Terminal: gitpod.F[any](map[string]interface{}{}),
73+
Machine: gitpod.F[any](map[string]interface{}{}),
7574
}),
7675
Session: gitpod.F("session"),
7776
SpecVersion: gitpod.F("specVersion"),
@@ -161,8 +160,7 @@ func TestEnvironmentAutomationServiceUpdateWithOptionalParams(t *testing.T) {
161160
Environment: gitpod.F([]string{"string"}),
162161
Image: gitpod.F("x"),
163162
}),
164-
Machine: gitpod.F[any](map[string]interface{}{}),
165-
Terminal: gitpod.F[any](map[string]interface{}{}),
163+
Machine: gitpod.F[any](map[string]interface{}{}),
166164
}),
167165
}),
168166
Status: gitpod.F(gitpod.EnvironmentAutomationServiceUpdateParamsStatus{

environmentautomationtask_test.go

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,7 @@ func TestEnvironmentAutomationTaskNewWithOptionalParams(t *testing.T) {
6565
Environment: gitpod.F([]string{"string"}),
6666
Image: gitpod.F("x"),
6767
}),
68-
Machine: gitpod.F[any](map[string]interface{}{}),
69-
Terminal: gitpod.F[any](map[string]interface{}{}),
68+
Machine: gitpod.F[any](map[string]interface{}{}),
7069
}),
7170
}),
7271
})
@@ -150,8 +149,7 @@ func TestEnvironmentAutomationTaskUpdateWithOptionalParams(t *testing.T) {
150149
Environment: gitpod.F([]string{"string"}),
151150
Image: gitpod.F("x"),
152151
}),
153-
Machine: gitpod.F[any](map[string]interface{}{}),
154-
Terminal: gitpod.F[any](map[string]interface{}{}),
152+
Machine: gitpod.F[any](map[string]interface{}{}),
155153
}),
156154
}),
157155
})

shared/shared.go

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -567,17 +567,13 @@ type RunsOn struct {
567567
Docker RunsOnDocker `json:"docker"`
568568
// Machine runs the service/task directly on the VM/machine level.
569569
Machine interface{} `json:"machine"`
570-
// Terminal runs the service inside a managed PTY terminal in the devcontainer.
571-
// Users can attach to the terminal interactively via the terminal API.
572-
Terminal interface{} `json:"terminal"`
573-
JSON runsOnJSON `json:"-"`
570+
JSON runsOnJSON `json:"-"`
574571
}
575572

576573
// runsOnJSON contains the JSON metadata for the struct [RunsOn]
577574
type runsOnJSON struct {
578575
Docker apijson.Field
579576
Machine apijson.Field
580-
Terminal apijson.Field
581577
raw string
582578
ExtraFields map[string]apijson.Field
583579
}
@@ -616,9 +612,6 @@ type RunsOnParam struct {
616612
Docker param.Field[RunsOnDockerParam] `json:"docker"`
617613
// Machine runs the service/task directly on the VM/machine level.
618614
Machine param.Field[interface{}] `json:"machine"`
619-
// Terminal runs the service inside a managed PTY terminal in the devcontainer.
620-
// Users can attach to the terminal interactively via the terminal API.
621-
Terminal param.Field[interface{}] `json:"terminal"`
622615
}
623616

624617
func (r RunsOnParam) MarshalJSON() (data []byte, err error) {

0 commit comments

Comments
 (0)