Commit 7b27053
Fix CVE-2026-27143: bump Go toolchain to 1.25.9 (#21411)
* Fix CVE-2026-27143: bump Go toolchain to 1.25.9
Daily vulnerability scan (CLC-2243) flagged 13 Classic component
images with a critical Go stdlib vulnerability:
- CVE-2026-27143 (GO-2026-4868): compiler did not correctly check
underflow/overflow on arithmetic over induction variables in
loops, allowing invalid indexing at runtime that could lead to
memory corruption.
The vulnerability is fixed in Go 1.25.9 (and 1.26.2). Bump the
toolchain across the workspace:
- Set toolchain to go1.25.9 in all 71 go.mod files
- Update GO_VERSION in dev/image/Dockerfile and bump TRIGGER_REBUILD
so the CI dev-environment image installs the patched compiler
- Update GO_VERSION in .devcontainer/Dockerfile for dev consistency
Verified locally by rebuilding all 13 affected components with
GOTOOLCHAIN=go1.25.9 and confirming grype reports zero critical
findings.
Co-authored-by: Ona <no-reply@ona.com>
* Pin golangci-lint --go=1.24 to match CI image toolchain
The CI dev-environment image bundles golangci-lint v1.64.8 built with
Go 1.24, which refuses to lint code declaring "toolchain go1.25.9".
Pin the lint target to 1.24 so the existing image keeps working without
a rebuild. We don't use any 1.25 language features; the toolchain bump
only addresses CVE-2026-27143 in the Go stdlib.
Co-authored-by: Ona <no-reply@ona.com>
* Revert toolchain bumps; rely on CI image's system Go for fix
The previous commit bumped 'toolchain go1.25.9' across all 71 go.mod
files. That worked locally but broke the existing CI dev-environment
image, which:
1. ships golangci-lint v1.64.8 built with Go 1.24 (rejects modules
declaring toolchain >= 1.25)
2. has system Go 1.24.13, so GOTOOLCHAIN=auto downloads the 1.25.9
toolchain module — but that module's prebuilt tools dir lacks
'covdata', breaking 'go test -coverprofile' for any Go library
package.
Instead, leave the 'toolchain' directive at go1.24.13 and rely on the
new dev-environment image (which has system Go 1.25.9 from
dev/image/Dockerfile) to compile binaries with the patched stdlib.
Once branch CI publishes the new image, a follow-up commit will update
the image tag references in .gitpod.yml and the workflow files (same
two-step pattern as #21327).
Co-authored-by: Ona <no-reply@ona.com>
* Update dev-environment image to ona-clc-2243-fix-cve-2026-27143-bump-go-gha.275
This image was published by the previous run of this PR and contains
Go 1.25.9, which is needed to compile binaries free of CVE-2026-27143.
Switching the workflow and devcontainer references over so subsequent
CI runs use the patched toolchain.
Co-authored-by: Ona <no-reply@ona.com>
---------
Co-authored-by: Ona <no-reply@ona.com>1 parent 1b94773 commit 7b27053
82 files changed
Lines changed: 103 additions & 103 deletions
File tree
- .devcontainer
- .github/workflows
- components
- blobserve
- common-go
- content-service-api
- go
- typescript/util
- content-service
- docker-up
- ee/agent-smith
- cmd
- testbed
- testtarget
- gitpod-cli
- gitpod-db/go
- gitpod-protocol/go
- ide-metrics-api
- go
- ide-metrics
- ide-service-api/go
- ide-service
- ide
- code-desktop/status
- code/codehelper
- jetbrains
- cli
- launcher
- image-builder-api
- go
- image-builder-bob
- image-builder-mk3
- local-app-api
- go
- node-labeler
- openvsx-proxy
- public-api-server
- public-api/go
- registry-facade-api
- go
- registry-facade
- scrubber
- server/go
- service-waiter
- spicedb
- codegen
- supervisor-api
- go
- supervisor
- usage-api/go
- usage
- workspacekit
- ws-daemon-api
- go
- ws-daemon
- nsinsider
- seccomp-profile-installer
- ws-manager-api
- go
- ws-manager-bridge-api/go
- ws-manager-mk2
- ws-proxy
- dev
- addlicense
- blowtorch
- changelog
- gp-gcloud
- gpctl
- image
- kubecdl
- loadgen
- preview/previewctl
- rejector
- ssh-load-test
- version-manifest
- install/preview/prettylog
- operations/observability/mixins
- test
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
193 | 193 | | |
194 | 194 | | |
195 | 195 | | |
196 | | - | |
| 196 | + | |
197 | 197 | | |
198 | 198 | | |
199 | 199 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
112 | 112 | | |
113 | 113 | | |
114 | 114 | | |
115 | | - | |
| 115 | + | |
116 | 116 | | |
117 | 117 | | |
118 | 118 | | |
| |||
140 | 140 | | |
141 | 141 | | |
142 | 142 | | |
143 | | - | |
| 143 | + | |
144 | 144 | | |
145 | 145 | | |
146 | 146 | | |
| |||
187 | 187 | | |
188 | 188 | | |
189 | 189 | | |
190 | | - | |
| 190 | + | |
191 | 191 | | |
192 | 192 | | |
193 | 193 | | |
| |||
410 | 410 | | |
411 | 411 | | |
412 | 412 | | |
413 | | - | |
| 413 | + | |
414 | 414 | | |
415 | 415 | | |
416 | 416 | | |
| |||
463 | 463 | | |
464 | 464 | | |
465 | 465 | | |
466 | | - | |
| 466 | + | |
467 | 467 | | |
468 | 468 | | |
469 | 469 | | |
| |||
492 | 492 | | |
493 | 493 | | |
494 | 494 | | |
495 | | - | |
| 495 | + | |
496 | 496 | | |
497 | 497 | | |
498 | 498 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
115 | 115 | | |
116 | 116 | | |
117 | 117 | | |
118 | | - | |
| 118 | + | |
119 | 119 | | |
120 | 120 | | |
121 | 121 | | |
| |||
143 | 143 | | |
144 | 144 | | |
145 | 145 | | |
146 | | - | |
| 146 | + | |
147 | 147 | | |
148 | 148 | | |
149 | 149 | | |
| |||
190 | 190 | | |
191 | 191 | | |
192 | 192 | | |
193 | | - | |
| 193 | + | |
194 | 194 | | |
195 | 195 | | |
196 | 196 | | |
| |||
448 | 448 | | |
449 | 449 | | |
450 | 450 | | |
451 | | - | |
| 451 | + | |
452 | 452 | | |
453 | 453 | | |
454 | 454 | | |
| |||
501 | 501 | | |
502 | 502 | | |
503 | 503 | | |
504 | | - | |
| 504 | + | |
505 | 505 | | |
506 | 506 | | |
507 | 507 | | |
| |||
530 | 530 | | |
531 | 531 | | |
532 | 532 | | |
533 | | - | |
| 533 | + | |
534 | 534 | | |
535 | 535 | | |
536 | 536 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
| 14 | + | |
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
39 | | - | |
| 39 | + | |
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
| |||
93 | 93 | | |
94 | 94 | | |
95 | 95 | | |
96 | | - | |
| 96 | + | |
97 | 97 | | |
98 | 98 | | |
99 | 99 | | |
| |||
126 | 126 | | |
127 | 127 | | |
128 | 128 | | |
129 | | - | |
| 129 | + | |
130 | 130 | | |
131 | 131 | | |
132 | 132 | | |
| |||
216 | 216 | | |
217 | 217 | | |
218 | 218 | | |
219 | | - | |
| 219 | + | |
220 | 220 | | |
221 | 221 | | |
222 | 222 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
| 18 | + | |
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
37 | | - | |
| 37 | + | |
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
60 | 60 | | |
61 | 61 | | |
62 | 62 | | |
63 | | - | |
| 63 | + | |
64 | 64 | | |
65 | 65 | | |
66 | 66 | | |
| |||
93 | 93 | | |
94 | 94 | | |
95 | 95 | | |
96 | | - | |
| 96 | + | |
97 | 97 | | |
98 | 98 | | |
99 | 99 | | |
| |||
171 | 171 | | |
172 | 172 | | |
173 | 173 | | |
174 | | - | |
| 174 | + | |
175 | 175 | | |
176 | 176 | | |
177 | 177 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
| 18 | + | |
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
| 14 | + | |
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| |||
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
46 | | - | |
| 46 | + | |
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
| |||
0 commit comments