Skip to content

Commit 8c56441

Browse files
geroplona-agent
andcommitted
Revert toolchain bumps; rely on CI image's system Go for fix
The previous commit bumped 'toolchain go1.25.9' across all 71 go.mod files. That worked locally but broke the existing CI dev-environment image, which: 1. ships golangci-lint v1.64.8 built with Go 1.24 (rejects modules declaring toolchain >= 1.25) 2. has system Go 1.24.13, so GOTOOLCHAIN=auto downloads the 1.25.9 toolchain module — but that module's prebuilt tools dir lacks 'covdata', breaking 'go test -coverprofile' for any Go library package. Instead, leave the 'toolchain' directive at go1.24.13 and rely on the new dev-environment image (which has system Go 1.25.9 from dev/image/Dockerfile) to compile binaries with the patched stdlib. Once branch CI publishes the new image, a follow-up commit will update the image tag references in .gitpod.yml and the workflow files (same two-step pattern as #21327). Co-authored-by: Ona <no-reply@ona.com>
1 parent ef4bc5c commit 8c56441

72 files changed

Lines changed: 72 additions & 76 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

WORKSPACE.yaml

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -71,9 +71,5 @@ defaultVariant:
7171
[
7272
"sh",
7373
"-c",
74-
# --go=1.24 keeps lint compatible with the v1.64.x golangci-lint built into the
75-
# CI dev-environment image (which is itself built with Go 1.24). Our toolchain bump
76-
# to 1.25.9 only addresses CVE-2026-27143 in the Go stdlib; we don't use any 1.25
77-
# language features.
78-
"golangci-lint run --go=1.24 --disable govet,errcheck,staticcheck --allow-parallel-runners --timeout 15m",
74+
"golangci-lint run --disable govet,errcheck,staticcheck --allow-parallel-runners --timeout 15m",
7975
]

components/blobserve/go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ module github.com/gitpod-io/gitpod/blobserve
22

33
go 1.24.0
44

5-
toolchain go1.25.9
5+
toolchain go1.24.13
66

77
godebug tlsmlkem=0
88

components/common-go/go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ module github.com/gitpod-io/gitpod/common-go
22

33
go 1.24.0
44

5-
toolchain go1.25.9
5+
toolchain go1.24.13
66

77
godebug tlsmlkem=0
88

components/content-service-api/go/go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ module github.com/gitpod-io/gitpod/content-service/api
22

33
go 1.24.0
44

5-
toolchain go1.25.9
5+
toolchain go1.24.13
66

77
godebug tlsmlkem=0
88

components/content-service-api/typescript/util/go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ module github.com/gitpod-io/gitpod/content-service-api/util
22

33
go 1.24.0
44

5-
toolchain go1.25.9
5+
toolchain go1.24.13
66

77
godebug tlsmlkem=0
88

components/content-service/go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ module github.com/gitpod-io/gitpod/content-service
22

33
go 1.24.0
44

5-
toolchain go1.25.9
5+
toolchain go1.24.13
66

77
godebug tlsmlkem=0
88

components/docker-up/go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ module github.com/gitpod-io/gitpod/docker-up
22

33
go 1.24
44

5-
toolchain go1.25.9
5+
toolchain go1.24.13
66

77
godebug tlsmlkem=0
88

components/ee/agent-smith/cmd/testbed/go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@ module testbed
22

33
go 1.24
44

5-
toolchain go1.25.9
5+
toolchain go1.24.13
66

77
godebug tlsmlkem=0

components/ee/agent-smith/cmd/testtarget/go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@ module testtarget
22

33
go 1.24
44

5-
toolchain go1.25.9
5+
toolchain go1.24.13
66

77
godebug tlsmlkem=0

components/ee/agent-smith/go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ module github.com/gitpod-io/gitpod/agent-smith
22

33
go 1.24.0
44

5-
toolchain go1.25.9
5+
toolchain go1.24.13
66

77
godebug tlsmlkem=0
88

0 commit comments

Comments
 (0)