Fix test skip mechanism and update leeway to v0.10.8#21190
Merged
Conversation
The ifEnvVarNotSet function was only checking for undefined, but in CI environments variables can be set to empty strings. This caused tests to run when they should have been skipped, resulting in 401 errors. Now checks for both undefined and empty string values. Co-authored-by: Ona <no-reply@ona.com>
corneliusludmann
approved these changes
Dec 10, 2025
…pty-env-vars-gha.22
1072dc1 to
efae4dd
Compare
Contributor
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Co-authored-by: Ona <no-reply@ona.com>
…pty-env-vars-gha.25 Co-authored-by: Ona <no-reply@ona.com>
Co-authored-by: Ona <no-reply@ona.com>
Co-authored-by: Ona <no-reply@ona.com>
…pty-env-vars-gha.29 Co-authored-by: Ona <no-reply@ona.com>
Contributor
|
|
Co-authored-by: Ona <no-reply@ona.com>
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR includes multiple fixes and updates:
Changes
Test Skip Mechanism Fix
The
ifEnvVarNotSetutility was failing in CI because it only checked forundefined, but CI environments can set variables to empty strings. This caused tests to run without valid tokens, resulting in 401 errors.Solution: Updated to check for both
undefinedand empty strings:Leeway Updates
LEEWAY_CACHE_UPLOAD_IMMEDIATE=trueto enable new upload mechanismInstaller Fix
Commits
Testing