test: add unit tests for use-page-tree-actions hook (#1126)#1128
Merged
sw-factory-automations merged 1 commit intoMay 17, 2026
Conversation
Co-authored-by: Ona <no-reply@ona.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
Author
|
✅ UI verification skipped — this PR contains only test files and documentation updates. No UI components, pages, or layouts were changed. |
Collaborator
Author
|
✅ Post-merge verification skipped — |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1126
What
Adds 35 unit tests for the
usePageTreeActionshook insrc/components/sidebar/use-page-tree-actions.test.ts. This hook handles all sidebar page operations and had zero test coverage despite being the most complex hook in the sidebar domain.How
Tests follow the established mocking pattern from
use-database-rows.test.ts:computeSwapPositions,computeNest,computeUnnest,getDescendantIds,getNextSiblingPositionmocked to isolate mutation logic from already-tested tree computationCoverage by action
handleCreatehandleCreateDatabasehandleDuplicateduplicateDatabase, error handling for both pathshandleDeletehandleMoveUphandleMoveDownhandleNesthandleUnnesthandleToggleFavoriteTesting
pnpm lint— 0 errorspnpm typecheck— passespnpm test— 1953 tests pass (144 files).agents/quality.mdwith new test counts