Skip to content

Minor Refactor: Unused Import and Variable Typo in PicksSocialsComponent #1444

@SuperGrut

Description

@SuperGrut

File: PickSocialComponents


Issue 1 — Unused import: makeId

makeId is imported from @gitroom/nestjs-libraries/services/make.is but is never referenced anywhere in the component. This will likely trigger a lint warning/error and adds unnecessary noise to the import block.

Current code:

import { makeId } from '@gitroom/nestjs-libraries/services/make.is';

Fix: Remove the import entirely since it is not used.


Issue 2 — Variable name typo: exisingexisting

The variable returned by useExistingData() is named exising, which is a typo for existing. It is used in multiple places throughout the component, making it a consistent but incorrect spelling that hurts readability.

Current code:

const exising = useExistingData();

// used as:
exising.integration

Fix: Rename the variable to existing across all usages:

const existing = useExistingData();

// updated usages:
existing.integration

Steps to Reproduce

  1. Open picks.socials.component.tsx by cliking the link above
  2. Observe the unused makeId import at the top of the file
  3. Observe the exising variable name used in place of existing

Expected Behavior

  • No unused imports
  • Variable names are spelled correctly

Actual Behavior

  • makeId is imported but never used
  • exising is used instead of existing

Additional Notes

These are minor code quality issues with no functional impact, but fixing them will keep the codebase clean and lint-error-free.

Happy to open a PR and fix it

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions