Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
"@nest-lab/throttler-storage-redis": "^1.2.0",
"@nestjs/cli": "10.0.2",
"@nestjs/common": "^10.0.2",
"@nestjs/core": "^10.0.2",
"@nestjs/core": "^11.1.18",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The PR upgrades @nestjs/core to v11 while leaving the tightly coupled @nestjs/common at v10. This major version mismatch will likely cause a runtime error on startup.
Severity: CRITICAL

Suggested Fix

Both @nestjs/core and @nestjs/common should be on the same major version. Update @nestjs/common to the same v11 version as @nestjs/core in package.json and then run pnpm install to regenerate the lock file.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: package.json#L72

Potential issue: The `package.json` is being updated to use `@nestjs/core@11.1.18` while
`@nestjs/common` remains on v10. These two packages are tightly coupled within the
NestJS framework. Major version updates in NestJS, such as v11, introduce breaking
changes. This mismatch will likely lead to a runtime error during application startup
when `NestFactory.create()` is called, as it will try to use incompatible internal APIs.
The PR author's note, "Failed to update the pnpm-lock.yaml," strongly suggests that the
dependency resolution failed, confirming this incompatibility.

Did we get this right? 👍 / 👎 to inform future reviews.

"@nestjs/microservices": "^10.3.1",
"@nestjs/platform-express": "^10.0.2",
"@nestjs/schedule": "^4.0.0",
Expand Down
Loading