fix: stop likes/views/comments/share/save doubling#1532
Open
SuperGrut wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1436
What kind of change does this PR introduce?
The PR introduces a bug fix appearing in Analytics Page for Instagram where the total value of metrics like likes/views/comments/share/saves are appearing in 2x values.
Why was this change needed?
Issue Link - #1436
https://github.com/gitroomhq/postiz-app/blob/main/libraries/nestjs-libraries/src/integrations/social/instagram.provider.ts
To make the chart render a line (which requires at least 2 points), the backend was duplicating this value into two data points. This caused the frontend to sum both entries, displaying double the actual metric. For example, if actual Like counts were 2, it would display 4(2x of actual data) on analytics chart. Similarly, if comments were 2, it would display 4(2x of actual data).
Fix
Backend: Removed the duplicate data point for total_value metrics. Now pushes a single honest data point.
Frontend (ChartSocial): When a dataset has only one data point, a duplicate point is prepended so the chart can render a line and show actual data.
Checklist:
Put a "X" in the boxes below to indicate you have followed the checklist;