trailing comma and minor cleanup

Author: philocalyst

filetreelist/src/lib.rs

@@ -1,4 +1,3 @@
-// #![forbid(missing_docs)]
 #![forbid(unsafe_code)]
 #![deny(
 	mismatched_lifetime_syntaxes,

src/app.rs

@@ -138,9 +138,9 @@ impl Environment {
 		use crossbeam_channel::unbounded;
 		Self {
 			queue: Queue::new(),
-			theme: Default::default(),
-			key_config: Default::default(),
-			repo: RefCell::new(RepoPath::Path(Default::default())),
+			theme: Rc::default(),
+			key_config: Rc::default(),
+			repo: RefCell::new(RepoPath::Path(PathBuf::default())),
 			options: Rc::new(RefCell::new(Options::test_env())),
 			sender_git: unbounded().0,
 			sender_app: unbounded().0,
@@ -1097,7 +1097,7 @@ impl App {
 			Err(e) => {
 				log::error!("delete remote: {e:?}");
 				self.queue.push(InternalEvent::ShowErrorMsg(
-					format!("delete remote error:\n{e}",),
+					format!("delete remote error:\n{e}"),
 				));
 			}
 		}

src/components/status_tree.rs

@@ -22,7 +22,7 @@ use std::{borrow::Cow, cell::Cell, path::Path};
 
 //TODO: use new `filetreelist` crate
 
-///
+/// Renders the working-tree status as a tree.
 #[allow(clippy::struct_excessive_bools)]
 pub struct StatusTreeComponent {
 	title: String,
@@ -208,7 +208,7 @@ impl StatusTreeComponent {
 						w = width as usize
 					)
 				} else {
-					format!("  {indent_str}{collapse_char}{string}",)
+					format!("  {indent_str}{collapse_char}{string}")
 				};
 
 				Some(Span::styled(

src/popups/commit.rs

@@ -446,7 +446,7 @@ impl CommitPopup {
 			msg_source,
 			&mut msg,
 		)? {
-			log::error!("prepare-commit-msg hook rejection: {e}",);
+			log::error!("prepare-commit-msg hook rejection: {e}");
 		}
 		self.input.set_text(msg);
 

src/popups/create_branch.rs

@@ -131,7 +131,7 @@ impl CreateBranchPopup {
 			Err(e) => {
 				log::error!("create branch: {e}");
 				self.queue.push(InternalEvent::ShowErrorMsg(
-					format!("create branch error:\n{e}",),
+					format!("create branch error:\n{e}"),
 				));
 			}
 		}

src/popups/create_remote.rs

@@ -202,7 +202,7 @@ impl CreateRemotePopup {
 					Err(e) => {
 						log::error!("create remote: {e}");
 						self.queue.push(InternalEvent::ShowErrorMsg(
-							format!("create remote error:\n{e}",),
+							format!("create remote error:\n{e}"),
 						));
 					}
 				}

src/popups/log_search.rs

@@ -225,7 +225,7 @@ impl LogSearchPopupPopup {
 				),
 			)]),
 			Line::from(vec![Span::styled(
-				format!("[{x_summary}] summary",),
+				format!("[{x_summary}] summary"),
 				self.theme.text(
 					matches!(
 						self.selection,
@@ -235,7 +235,7 @@ impl LogSearchPopupPopup {
 				),
 			)]),
 			Line::from(vec![Span::styled(
-				format!("[{x_body}] message body",),
+				format!("[{x_body}] message body"),
 				self.theme.text(
 					matches!(
 						self.selection,
@@ -245,7 +245,7 @@ impl LogSearchPopupPopup {
 				),
 			)]),
 			Line::from(vec![Span::styled(
-				format!("[{x_files}] committed files",),
+				format!("[{x_files}] committed files"),
 				self.theme.text(
 					matches!(
 						self.selection,
@@ -255,7 +255,7 @@ impl LogSearchPopupPopup {
 				),
 			)]),
 			Line::from(vec![Span::styled(
-				format!("[{x_authors}] authors",),
+				format!("[{x_authors}] authors"),
 				self.theme.text(
 					matches!(
 						self.selection,

src/popups/rename_branch.rs

@@ -140,7 +140,7 @@ impl RenameBranchPopup {
 				Err(e) => {
 					log::error!("create branch: {e}");
 					self.queue.push(InternalEvent::ShowErrorMsg(
-						format!("rename branch error:\n{e}",),
+						format!("rename branch error:\n{e}"),
 					));
 				}
 			}

src/popups/rename_remote.rs

@@ -163,7 +163,7 @@ impl RenameRemotePopup {
 					Err(e) => {
 						log::error!("rename remote: {e}");
 						self.queue.push(InternalEvent::ShowErrorMsg(
-							format!("rename remote error:\n{e}",),
+							format!("rename remote error:\n{e}"),
 						));
 					}
 				}

src/popups/tag_commit.rs

@@ -196,7 +196,7 @@ impl TagCommitPopup {
 
 					log::error!("e: {e}");
 					self.queue.push(InternalEvent::ShowErrorMsg(
-						format!("tag error:\n{e}",),
+						format!("tag error:\n{e}"),
 					));
 				}
 			}