Fix #315 run brew test in CI#2596
Merged
Merged
Conversation
Collaborator
|
@peso thanks for looking into this. any idea why this checks out |
Contributor
Author
|
The gitui 0.7.0 puzzled me as well, but it is simply test data for the brew ui test. |
Collaborator
|
@peso thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes #315 .
It changes the following:
I followed the checklist:
make checkwithout errors..but, I did make a custom tap of brew, introduced an error in the source code on my fork and let my custom brew discover it.
The thing is, there is no change to the source code of gitui, only to the CI script. The change looks at gitui main branch head, which I cannot touch - so I had to hack around to fake a test. I have demonstrated that it works on my fork, but not that it works on gitui master branch.