Fixes for issue 425 - Postgres schema files for newsletter_*.sql files fail at install#426
Open
karlstevens wants to merge 2 commits into
Open
Fixes for issue 425 - Postgres schema files for newsletter_*.sql files fail at install#426karlstevens wants to merge 2 commits into
karlstevens wants to merge 2 commits into
Conversation
Used 'text' instead of 'longtext' should work; Mysql longtext is 4GB while Postgresql text is 1GB. I'm assuming that 4GB is used for Mysql as the next shortest (mediumtext) is 16MB.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed instances of "tinyint" to "smallint", "largetext" to "text", "unsigned" to "bigint" and "datetime" to "timestamp"
I selected "bigint" for unsigned to make sure there would be no overflow (I'm not sure how large the values are.)
Mysql's "largetext" can hold values up to 4GB; the closest Postgres has (without using blobs) is "text", which can hold up to 1GB; I hope this is large enough.