WebGPUPathTracer: Use half float storage target w/ Kahan summation#749
Closed
gkjohnson wants to merge 18 commits intowebgpu-pathtracerfrom
Closed
WebGPUPathTracer: Use half float storage target w/ Kahan summation#749gkjohnson wants to merge 18 commits intowebgpu-pathtracerfrom
gkjohnson wants to merge 18 commits intowebgpu-pathtracerfrom
Conversation
PathTracerMegaKernel: Remove all string-based dependencies
…ring arguments as-needed
Owner
Author
|
I'm a bit worried about precision loss on this - it looks okay in this simple scene and simple BRDF but I expect with enough samples and with high enough values we'd start to see some degradation. The primary issue is that float textures are not guaranteed to be filterable but they do seem to always be available in WebGPU (outside of compatibility mode). It may be best to implement custom filtering when writing to the canvas if filtering isn't available. |
Owner
Author
|
Closing in favor of #750 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relies on #748
Related to #133
npm start -- --mode=ssl --hostWith these changes both the wavefront and megakernel path tracers work on my phone 🎉
cc @TheBlek