fixed cppcheck-opensource#504 / refs cppcheck-opensource#507 - cleaned up and improved parsing of #line preprocessor directive (cppcheck-opensource#586)

Author: firewave

simplecpp.cpp

@@ -699,42 +699,44 @@ void simplecpp::TokenList::readfile(Stream &stream, const std::string &filename,
 
             if (oldLastToken != cback()) {
                 oldLastToken = cback();
-                const Token * const llTok = isLastLinePreprocessor();
-                if (!llTok)
+
+                // #line 3
+                // #line 3 "file.c"
+                // #3
+                // #3 "file.c"
+                const Token * ppTok = isLastLinePreprocessor();
+                if (!ppTok)
                     continue;
-                const Token * const llNextToken = llTok->next;
-                if (!llTok->next)
+
+                const auto advanceAndSkipComments = [](const Token* tok) {
+                    do {
+                        tok = tok->next;
+                    } while (tok && tok->comment);
+                    return tok;
+                };
+
+                // skip #
+                ppTok = advanceAndSkipComments(ppTok);
+                if (!ppTok)
                     continue;
-                if (llNextToken->next) {
-                    // TODO: add support for "# 3"
-                    // #3 "file.c"
-                    // #line 3 "file.c"
-                    if ((llNextToken->number &&
-                         llNextToken->next->str()[0] == '\"') ||
-                        (llNextToken->str() == "line" &&
-                         llNextToken->next->number &&
-                         llNextToken->next->next &&
-                         llNextToken->next->next->str()[0] == '\"'))
-                    {
-                        const Token *strtok = cback();
-                        while (strtok->comment)
-                            strtok = strtok->previous;
-                        const Token *numtok = strtok->previous;
-                        while (numtok->comment)
-                            numtok = numtok->previous;
-                        lineDirective(fileIndex(replaceAll(strtok->str().substr(1U, strtok->str().size() - 2U),"\\\\","\\")),
-                                      std::atol(numtok->str().c_str()), location);
-                    }
-                    // #line 3
-                    else if (llNextToken->str() == "line" &&
-                             llNextToken->next->number)
-                    {
-                        const Token *numtok = cback();
-                        while (numtok->comment)
-                            numtok = numtok->previous;
-                        lineDirective(location.fileIndex, std::atol(numtok->str().c_str()), location);
-                    }
-                }
+
+                if (ppTok->str() == "line")
+                    ppTok = advanceAndSkipComments(ppTok);
+
+                if (!ppTok || !ppTok->number)
+                    continue;
+
+                const unsigned int line = std::atol(ppTok->str().c_str());
+                ppTok = advanceAndSkipComments(ppTok);
+
+                unsigned int fileindex;
+
+                if (ppTok && ppTok->str()[0] == '\"')
+                    fileindex = fileIndex(replaceAll(ppTok->str().substr(1U, ppTok->str().size() - 2U),"\\\\","\\"));
+                else
+                    fileindex = location.fileIndex;
+
+                lineDirective(fileindex, line, location);
             }
 
             continue;

test.cpp

@@ -2413,7 +2413,8 @@ static void location8()
         "# 3\n"
         "__LINE__ __FILE__\n";
     ASSERT_EQUALS("\n"
-                  "2 \"\"", // TODO: should say 3
+                  "\n"
+                  "3 \"\"",
                   preprocess(code));
 }
 
@@ -2454,6 +2455,17 @@ static void location11()
                   preprocess(code));
 }
 
+static void location12()
+{
+    const char code[] =
+        "/**//**/#/**//**/line/**//**/3/**//**/\"file.c\"/**/\n"
+        "__LINE__ __FILE__\n";
+    ASSERT_EQUALS("\n"
+                  "#line 3 \"file.c\"\n"
+                  "3 \"file.c\"",
+                  preprocess(code));
+}
+
 static void missingHeader1()
 {
     const char code[] = "#include \"notexist.h\"\n";
@@ -4060,6 +4072,7 @@ static void runTests(int argc, char **argv, Input input)
     TEST_CASE(location9);
     TEST_CASE(location10);
     TEST_CASE(location11);
+    TEST_CASE(location12);
 
     TEST_CASE(missingHeader1);
     TEST_CASE(missingHeader2);