You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@jan-janssen I just want to point out one subtle point, which is that on main the calculation runs to completion inside a worker process spawned by the API.
I.e. /check is just checking whether that process has written the results to the top-level task store, /check is not using executorlib.
In my branch I move to a mode where /submit does a fire-and-forget submission to executorlib, while /check uses executorlib to check the status of the job.
@jan-janssen I just want to point out one subtle point, which is that on main the calculation runs to completion inside a worker process spawned by the API.
Yes, I just want to separate the pull request into multiple steps to simplify the debugging.
I.e. /check is just checking whether that process has written the results to the top-level task store, /check is not using executorlib.
I agree with this strategy.
In my branch I move to a mode where /submit does a fire-and-forget submission to executorlib, while /check uses executorlib to check the status of the job.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently still requires
shutdown(wait=True, cancel_futures=False).