Skip to content

Switch from SingleNodeExecutor to TestClusterExecutor - #128

Closed
jan-janssen wants to merge 5 commits into
mainfrom
TestClusterExecutor
Closed

Switch from SingleNodeExecutor to TestClusterExecutor#128
jan-janssen wants to merge 5 commits into
mainfrom
TestClusterExecutor

Conversation

@jan-janssen

@jan-janssen jan-janssen commented Feb 13, 2026

Copy link
Copy Markdown
Contributor

Currently still requires shutdown(wait=True, cancel_futures=False).

@jan-janssen
jan-janssen marked this pull request as draft February 13, 2026 12:10
@github-actions

github-actions Bot commented Feb 13, 2026

Copy link
Copy Markdown
Contributor

@ltalirz

ltalirz commented Feb 14, 2026

Copy link
Copy Markdown
Contributor

@jan-janssen I just want to point out one subtle point, which is that on main the calculation runs to completion inside a worker process spawned by the API.

I.e. /check is just checking whether that process has written the results to the top-level task store, /check is not using executorlib.

In my branch I move to a mode where /submit does a fire-and-forget submission to executorlib, while /check uses executorlib to check the status of the job.

@jan-janssen

Copy link
Copy Markdown
Contributor Author

@jan-janssen I just want to point out one subtle point, which is that on main the calculation runs to completion inside a worker process spawned by the API.

Yes, I just want to separate the pull request into multiple steps to simplify the debugging.

I.e. /check is just checking whether that process has written the results to the top-level task store, /check is not using executorlib.

I agree with this strategy.

In my branch I move to a mode where /submit does a fire-and-forget submission to executorlib, while /check uses executorlib to check the status of the job.

To simplify this I implemented pyiron/executorlib#915 and pyiron/executorlib#914 .

@ltalirz

ltalirz commented Feb 18, 2026

Copy link
Copy Markdown
Contributor

superseded by #121

@ltalirz ltalirz closed this Feb 18, 2026
@ltalirz
ltalirz deleted the TestClusterExecutor branch March 14, 2026 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants