Add option to ignore failed fans#180
Open
odenbach wants to merge 2 commits into
Open
Conversation
Owner
|
can you add test case for new scenarios? and add documentation of the option in the plugin file as pod so check_raid users would be aware of the new option. as no other plugin has documentation in pod, use your imagination |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I have a box with some fans in it which are connected to the mainboard instead of the enclosure. The mainboard reports all fans as working properly. tw-cli however reports the fans as failed (as they are not connected). I reported this to the manufacturer and they told me to simply ignore the fan warnings in tw-cli's output.
So this pull request adds a simple plugin option 'ignore-fans=1' which then disables checking of fans (and of the main enclosure status which goes to WARNING if anything seems b0rken).
Thanks,
Christopher
tw-cli.txt