home-manager: incorporation of suggestions from @feeeyli#13
Open
philocalyst wants to merge 2 commits into
Open
home-manager: incorporation of suggestions from @feeeyli#13philocalyst wants to merge 2 commits into
philocalyst wants to merge 2 commits into
Conversation
builds on and extends the module implemented in glide-browser#10 with the discussions raised in glide-browser/glide#147 (comment) Implemented as a single file as is customary in home-manager proper. Co-authored-by: @feeyli
Member
|
This is so cool, thank you for porting this :) It'd be even better if we could provide a similar API for non home-manager users, so they can easily configure glide through nix - obviously it can't be exactly the same as we can't know where the config should live, but we could provide a function that returns a config string? I have no real idea what that would look like though, do you? |
Author
|
I don't know what exactly these users would be wanting in the building of this API:
Do they use flakes?
Do they not want the dependency?
Definitely possible to just provide a function that takes an attrset, though.
▰▰▰▰▰
Miles Wirth 🙃
… From: Robert Craigie ***@***.***>
Sent: 13 March 2026 09:57
To: "glide-browser/glide.nix" ***@***.***>
Cc: Miles Wirht ***@***.***>, Author ***@***.***>
Subject: Re: [glide-browser/glide.nix] home-manager: incorporation of suggestions from @feeeyli (PR #13)
RobertCraigie left a comment (glide-browser/glide.nix#13)
This is so cool, thank you for porting this :)
It'd be even better if we could provide a similar API for non home-manager users, so they can easily configure glide through nix - obviously it can't be _exactly_ the same as we can't know _where_ the config should live, but we could provide a function that returns a config string?
I have no real idea what that would look like though, do you?
--
Reply to this email directly or view it on GitHub:
#13 (comment)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
Really... untested...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
builds on and extends the module implemented in #10 with the discussions raised in
glide-browser/glide#147 (comment)
Implemented as a single file as is customary in home-manager proper.
Co-authored-by: @feeeyli