Skip to content

Update F to explicitly create a new tab #202

@RobertCraigie

Description

@RobertCraigie

I couldn't reproduce the issue in #165 (reply in thread) but the way we implement it right now feels quite hacky

const previous = hint.element.getAttribute("target");
try {
hint.element.setAttribute("target", "_blank");
hint.element.focus();
where we just override the target to _blank.

Instead of overriding target we could just use the newer hint callback execution context to extract the url and call browser.tabs.create() ourselves. I'm not sure offhand how equivalent that API is to a cmd+click directly, so that would need some research.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions