Skip to content

Commit 3053f78

Browse files
authored
Merge pull request #159 from glideapps/add-deprecation-label
feat: 🏷️ add deprecated fields to JSON and fetch
2 parents 4908bfe + 70c19a7 commit 3053f78

5 files changed

Lines changed: 13 additions & 1 deletion

File tree

src/columns/create-json-object.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@ const run: glide.Column = (
8080

8181
export default glide.column({
8282
name: "Make JSON Object",
83+
deprecated: true,
8384
category: "Code",
8485
released: "direct",
8586
description: "Returns a JSON Object String",

src/columns/fetch.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ const run: glide.Column = async (url, query) => {
2626
};
2727

2828
export default glide.column({
29+
deprecated: true,
2930
name: "Fetch JSON",
3031
category: "Data & APIs",
3132
released: "sandboxed",

src/columns/jq.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ const run: glide.Column = async (json, query) => {
2323

2424
export default glide.column({
2525
name: "Transform JSON",
26+
deprecated: true,
2627
category: "Data & APIs",
2728
released: "direct",
2829
description: "Transform JSON with JQ",

src/components/REPL.tsx

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ const REPL: React.VFC<ColumnDefinition<any>> = props => {
1313
run,
1414
tests = [],
1515
example = tests.length > 0 ? tests[0].params : {},
16+
deprecated
1617
} = props;
1718

1819
const [result, setResult] = useState<any>();
@@ -37,6 +38,12 @@ const REPL: React.VFC<ColumnDefinition<any>> = props => {
3738

3839
return (
3940
<div className="p-5">
41+
{deprecated ? (
42+
<div className="bg-yellow-100 border-l-4 border-yellow-500 text-yellow-700 p-4 mb-4" role="alert">
43+
<p className="font-bold">Deprecated Column</p>
44+
<p className="my-2">Glide apps that already use this column will continue to work, but the column will no longer be available for new configurations.</p>
45+
</div>
46+
) : null}
4047
<div className="space-y-6">
4148
{Object.values(params).map((p, i) => (
4249
<div key={i}>

src/glide.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,7 @@ type Released = "direct" | "sandboxed";
8585
export type Manifest = {
8686
name: string;
8787
category: Category;
88+
deprecated?: boolean;
8889
released?: Released;
8990
description: string;
9091
author: string;
@@ -125,7 +126,7 @@ export function column<TColumnParams>(manifest: ColumnDefinition<TColumnParams>)
125126
export function toStrictManifest(convenient: ManifestConvenient<any>): Manifest {
126127
// We carefully pick out just the props in manifest, because more
127128
// could come in from the component.
128-
const { name, category, released, description, author, result, params, about, video } = convenient;
129+
const { name, category, released, description, author, result, params, about, video, deprecated } = convenient;
129130
const icon = getIconForManifest(convenient);
130131

131132
return {
@@ -138,6 +139,7 @@ export function toStrictManifest(convenient: ManifestConvenient<any>): Manifest
138139
about,
139140
icon,
140141
video,
142+
deprecated,
141143
params: Object.entries(params).map(([name, param]) => ({
142144
name,
143145
...param,

0 commit comments

Comments
 (0)