Promote forms check to default checks (#39)

The forms check cross-references action formData.get() calls against
form input names, catching missing fields deterministically with no
false positives. Previously opt-in, now runs by default.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Author: rwdaigle

README.md

@@ -12,7 +12,7 @@ npm install -g roto-rooter
 rr [OPTIONS] [FILES...]
 ```
 
-Point `rr` at your project and it scans your route files for issues. With no arguments it runs the **default checks** (links, loader, params, interactivity, hydration) against all files in the current directory.
+Point `rr` at your project and it scans your route files for issues. With no arguments it runs the **default checks** (links, forms, loader, params, interactivity, hydration) against all files in the current directory.
 
 | Option                    | Description                                                                                                                                                                                       |
 | ------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
@@ -30,7 +30,7 @@ Point `rr` at your project and it scans your route files for issues. With no arg
 - **params** (default) -- ensures `useParams()` only accesses params defined in the route path
 - **interactivity** (default) -- catches "Save" buttons that don't save, "Delete" buttons that don't delete, and empty click handlers
 - **hydration** (default) -- detects SSR/client mismatches from `new Date()`, `Math.random()`, locale-dependent formatting, `window` access in render
-- **forms** (opt-in) -- validates `<Form>` targets have actions and that field names match `formData.get()` calls
+- **forms** (default) -- validates `<Form>` targets have actions and that field names match `formData.get()` calls
 - **drizzle** (opt-in) -- validates Drizzle ORM operations against your schema (missing columns, type mismatches, etc.)
 
 **Example output:**

SKILL.md

@@ -36,7 +36,7 @@ Example output:
 rr [FILES...]                   # analyze files (default: all routes)
 rr --check links,forms          # run specific checks
 rr --check all                  # run all checks (including optional)
-rr --check defaults,forms       # run default checks plus specific optional checks
+rr --check defaults,drizzle     # run default checks plus specific optional checks
 rr --format json                # JSON output
 rr --root ./my-app              # set project root
 rr sql --drizzle                # extract SQL queries from Drizzle ORM code
@@ -48,14 +48,14 @@ rr sql --drizzle --format json  # SQL extraction with JSON output
 **Default checks** (run automatically):
 
 - **links** - validates `<Link>`, `<NavLink>`, `redirect()`, `navigate()`, and `href` props on any component exist as routes
+- **forms** - validates Form action targets, field alignment between forms and actions, intent-based dispatch
 - **loader** - detects loader data usage issues and `clientLoader`/`clientAction` with server-only imports
 - **params** - validates route params match definitions
 - **interactivity** - detects disconnected dialogs ("Save" buttons that don't save, "Delete" buttons that don't delete, stub handlers)
 - **hydration** - detects hydration mismatches (Date, Math.random, locale-dependent formatting, window access in render)
 
 **Optional checks** (opt-in via `--check`):
 
-- **forms** - validates Form action targets and method/action mismatches
 - **drizzle** - validates database operations against Drizzle ORM schema (unknown tables/columns, missing required columns, null-to-notNull, invalid enum literals, type mismatches, auto-generated column writes, DELETE/UPDATE without WHERE)
 
 ## Examples

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "roto-rooter",
-  "version": "0.8.7",
+  "version": "0.9.0",
   "description": "Static analysis and functional verifier tool for React Router applications",
   "main": "./dist/index.js",
   "types": "./dist/index.d.ts",

package.json

@@ -24,14 +24,15 @@ import {
 // Checks that run by default when no --check is specified
 export const DEFAULT_CHECKS = [
   'links',
+  'forms',
   'loader',
   'params',
   'interactivity',
   'hydration',
 ];
 
 // Checks that are available but disabled by default (opt-in)
-export const OPTIONAL_CHECKS = ['forms', 'drizzle'];
+export const OPTIONAL_CHECKS = ['drizzle'];
 
 // All available checks
 export const ALL_CHECKS = [...DEFAULT_CHECKS, ...OPTIONAL_CHECKS];

src/analyzer.ts

@@ -404,8 +404,8 @@ OPTIONS:
   -v, --version           Show version number
   -f, --format <format>   Output format: text (default) or json
   -c, --check <checks>    Comma-separated list of checks to run
-                          Aliases: "defaults" (links, loader, params, interactivity, hydration), "all"
-                          Optional: forms, drizzle
+                          Aliases: "defaults" (links, forms, loader, params, interactivity, hydration), "all"
+                          Optional: drizzle
   -r, --root <path>       Project root directory containing the app/ folder (default: cwd)
   --fix                   Automatically fix issues where possible
   --dry-run               Show what would be fixed without modifying files
@@ -421,8 +421,8 @@ EXAMPLES:
   # Run only link and form checks
   rr --check links,forms
 
-  # Run default checks plus forms
-  rr --check defaults,forms
+  # Run default checks plus drizzle
+  rr --check defaults,drizzle
 
   # Run all checks (including optional ones)
   rr --check all