Skip to content

Promote forms check to default checks#39

Merged
rwdaigle merged 1 commit into
mainfrom
ryan/analyze-glide-app
Feb 24, 2026
Merged

Promote forms check to default checks#39
rwdaigle merged 1 commit into
mainfrom
ryan/analyze-glide-app

Conversation

@rwdaigle
Copy link
Copy Markdown
Contributor

@rwdaigle rwdaigle commented Feb 24, 2026

Summary

  • Moves the forms check from opt-in (OPTIONAL_CHECKS) to DEFAULT_CHECKS, so it runs automatically without --check forms
  • The forms check cross-references formData.get() calls in actions against form input name attributes, catching missing fields deterministically
  • Updates CLI help text, SKILL.md, and README.md to reflect the change
  • Bumps version to 0.9.0

Test plan

  • All 206 existing tests pass (no behavior change for explicit --check forms usage)
  • Verified rr --root <app> now catches form field mismatches without --check forms
  • CLI help text shows forms in defaults list
  • typecheck, build, and tests all green

🤖 Generated with Claude Code


Open with Devin

Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

The forms check cross-references action formData.get() calls against
form input names, catching missing fields deterministically with no
false positives. Previously opt-in, now runs by default.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@rwdaigle rwdaigle force-pushed the ryan/analyze-glide-app branch from fe45c75 to 4113d95 Compare February 24, 2026 23:26
@rwdaigle rwdaigle merged commit e3ff7ba into main Feb 24, 2026
2 checks passed
@rwdaigle rwdaigle deleted the ryan/analyze-glide-app branch February 24, 2026 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant