Add sql<number> aggregate type assertion check#40
Merged
Conversation
Detects sql<number> tagged templates containing aggregate functions (SUM, AVG, COUNT, MIN, MAX). Databases return these as strings, creating silent runtime type mismatches. Severity: error, category: drizzle. Includes test fixture with 5 bad patterns and 4 safe patterns, comprehensive test coverage with 7 new tests, all 213 tests passing. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sql<number>tagged templates containing SQL aggregate functions (SUM, AVG, COUNT, MIN, MAX)<number>generic is a false assertion that creates silent runtime type mismatchesDetails
sql<T>generic containsnumberAND SQL body contains aggregate keywordsVerified