Fix drizzle false positive for non-db .delete() calls#43
Merged
Conversation
…s.delete() etc. Track known db variable names (imported or aliased) and verify .delete()/.insert()/.update() callers are actual database clients before treating them as DB operations. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
URLSearchParams.delete(),Map.delete(),Set.delete()etc. were incorrectly flagged as database DELETE operations by the drizzle/persistence checkdbvariable names (including import aliases) and verify.delete()/.insert()/.update()callers are actual database clients before treating them as DB operationsTest plan
non-db-delete.tsxfixture with URLSearchParams, Map, and Set.delete()callsextractDbOperationsreturns zero delete ops for the fixturecheckPersistenceproduces no "no .where()" issues for the fixture🤖 Generated with Claude Code