Skip to content

Commit 4918f3e

Browse files
committed
feat: improve inline error icon position
1 parent e33ab64 commit 4918f3e

File tree

6 files changed

+43
-1
lines changed

6 files changed

+43
-1
lines changed

src/@next/InlineError/InlineErrorStyle.ts

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,23 @@ import styled from 'styled-components';
22
import { space4 } from '../utilities/spacing';
33
import { Typography } from '../Typography';
44
import { Red } from '../utilities/colors';
5+
import { Breakpoints } from '..';
56

67
export const StyledWrapper = styled.div`
78
display: flex;
8-
align-items: center;
9+
align-items: flex-start;
910
gap: ${space4};
11+
12+
svg {
13+
flex-shrink: 0;
14+
}
15+
16+
@media (max-width: ${Breakpoints.large}) {
17+
svg {
18+
height: 18px;
19+
width: 18px;
20+
}
21+
}
1022
`;
1123

1224
export const StyledText = styled(Typography)`

test/e2e/inlineError/inlineError.spec.ts

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,3 +6,33 @@ test('Inline Error - default', async ({ page }) => {
66
await inlineError.goto();
77
await expect(inlineError.container).toHaveScreenshot('inlineError.png');
88
});
9+
10+
test('Inline Error - default (small device)', async ({ page }) => {
11+
page.setViewportSize({ width: 768, height: 600 });
12+
13+
const inlineError = new InlineErrorPage(page);
14+
await inlineError.goto();
15+
await expect(inlineError.container).toHaveScreenshot('inlineError-small.png');
16+
});
17+
18+
test('Inline Error - multi line', async ({ page }) => {
19+
const inlineError = new InlineErrorPage(page);
20+
await inlineError.goto(
21+
'args=text:This%20is%20a%20very%20long%20error%20message%20that%20will%20wrap%20to%20multiple%20lines%20that%20will%20wrap%20to%20multiple%20lines%20will%20wrap%20to%20multiple%20lines%20that%20will%20wrap%20to%20multiple%20lines%20is%20a%20very%20long%20error%20message%20that%20will%20wrap%20to%20multiple%20lines%20that%20will%20wrap%20to%20multiple%20lines%20will%20wrap%20to%20multiple%20lines%20that%20will%20wrap%20to%20multiple%20lines'
22+
);
23+
await expect(inlineError.container).toHaveScreenshot(
24+
'inlineError-multi-line.png'
25+
);
26+
});
27+
28+
test('Inline Error - multi line (small device)', async ({ page }) => {
29+
page.setViewportSize({ width: 768, height: 600 });
30+
31+
const inlineError = new InlineErrorPage(page);
32+
await inlineError.goto(
33+
'args=text:This%20is%20a%20very%20long%20error%20message%20that%20will%20wrap%20to%20multiple%20lines%20that%20will%20wrap%20to%20multiple%20lines%20will%20wrap%20to%20multiple%20lines%20that%20will%20wrap%20to%20multiple%20lines'
34+
);
35+
await expect(inlineError.container).toHaveScreenshot(
36+
'inlineError-small-multi-line.png'
37+
);
38+
});
-37 Bytes
Loading
15.7 KB
Loading
2.15 KB
Loading
8.76 KB
Loading

0 commit comments

Comments
 (0)